London|May 2025|Alexandru Pocovnicu|Coursework/sprint 3 #639

alexandru-pocovnicu · 2025-07-04T10:40:01Z

Learners, PR Template

Self checklist

I have committed my files one by one, on purpose, and for a reason
I have titled my PR with REGION | COHORT_NAME | FIRST_NAME LAST_NAME | PROJ_NAME
I have tested my changes
My changes follow the style guide
My changes meet the requirements of this task

Changelist

Briefly explain your PR.

Questions

Ask any questions you have for your reviewer.

Sprint-3/2-mandatory-rewrite/1-get-angle-type.js

cjyuan · 2025-07-15T22:37:18Z

Sprint-3/2-mandatory-rewrite/1-get-angle-type.test.js

+test("should identify reflex angle(230°)",()=>{
+  expect(getAngleType(230)).toEqual("Reflex angle")
+});


To ensure thorough testing, we need broad scenario coverage. Listing individual values, however, can quickly lead to an unmanageable number of test cases.
Instead of writing tests for individual angles, consider grouping all possible input values into meaningful categories. Then, select representative samples from each category to test. This approach improves coverage and makes our tests easier to maintain. For example,

test("should identify reflex angle (180 < angle < 360)", () => { expect(getAngleType(300)).toEqual("Reflex angle"); expect(getAngleType(359.999)).toEqual("Reflex angle"); expect(getAngleType(180.001)).toEqual("Reflex angle"); });

thank you...is it possible to test a negative in this case, if i add 'else' it affects the other tests

angle <= 0 should be considered as an invalid angle.

cjyuan · 2025-07-15T22:39:18Z

Sprint-3/2-mandatory-rewrite/2-is-proper-fraction.js

@@ -1,5 +1,9 @@
 function isProperFraction(numerator, denominator) {
-    if (numerator < denominator) return true;
+    if (isNaN(numerator) || isNaN(denominator)) return NaN;


Could also return false. Technically if any of the parameter is NaN, then it cannot represent a proper fraction.

Sorry but I do not understand, I don't seem to have this line if (numerator < denominator) return true; in my code

I mean, instead of returning NaN, you could return false.

Red-highlighted lines are removed lines, and green-highlighted lines are new additions to the file.

Sprint-3/2-mandatory-rewrite/2-is-proper-fraction.js

cjyuan · 2025-07-15T22:42:06Z

Sprint-3/2-mandatory-rewrite/3-get-card-value.js

+    if (rank === "A") return 11;
+    if(rank>=2 && rank<10)return Number(rank);


In JavaScript, strings that represent valid numeric literals in the language can be safely converted to equivalent numbers. For examples, "0x02", "2.1", or "00_02".

Does your function return the value you expected from each of the following function calls?

getCardValue("0x02♠"); getCardValue("2.1♠"); getCardValue("00_02♠");

getCardValue("00_02♠"); it doesn't for this one, from my understanding the result of that should be 2♠ , I wrote a test for 2♠, but i still cant figure it out, sorry

In your case "00_02" should not satisfy the condition at line 5. The other two do.

A few more cases:

getCardValue("3e0♠"); getCardValue("000002♠");

You would need a stricter check to ensure rank is one of the 9 possible number ranks before you convert it to a number.

cjyuan · 2025-07-15T22:50:14Z

Sprint-3/3-mandatory-practice/implement/get-ordinal-number.test.js

+test("should return '2nd' for 2", () => {
+  expect(getOrdinalNumber(2)).toEqual("2nd");
+});


Instead of writing tests for individual numbers, consider grouping all possible input values into meaningful categories. For example, we can prepare a test for numbers 2, 22, 132, etc. as

test("append 'nd' to numbers ending in 2, except those ending in 12", () => { expect( getOrdinalNumber(2) ).toEqual("2nd"); expect( getOrdinalNumber(22) ).toEqual("22nd"); expect( getOrdinalNumber(132) ).toEqual("132nd"); });

Can you update the tests in this script so that they can cover all possible valid numbers?

cjyuan · 2025-07-15T22:52:19Z

Sprint-3/3-mandatory-practice/implement/get-ordinal-number.js

+    if (isNaN(num)) {
+      return NaN;
+    }


The function is expected to return a string, so even if the parameter is not an integer, it is better to return a string instead of NaN.

Could also consider using Number.isInteger() to check if a value is an integer.

cjyuan · 2025-07-15T22:53:27Z

Sprint-3/3-mandatory-practice/implement/repeat.js

+    if(count<0){
+        return "negative number"
+    }


How would the caller distinguish the result of the following two function calls?

repeat("negative number", 1)

repeat("", -1)

Both function calls return the same value.

cjyuan · 2025-07-15T22:53:52Z

Sprint-3/3-mandatory-practice/implement/repeat.test.js

+test("should repeat the string count times", () => {
+    const str = "hello";
+    const count = -1;
+    const repeatedStr = repeat(str, count);
+    expect(repeatedStr).toEqual("negative number");
+  });


If you modified repeat() to throw an error when count is negative, and you wanted to test if the function can throw an error as expected, you can use .toThrow(). You can find out more about how to use .toThrow() here: https://jestjs.io/docs/expect#tothrowerror (Note: Pay close attention to the syntax of the example)

cjyuan · 2025-07-15T23:00:25Z

Sprint-3/4-stretch-investigate/password-validator.test.js

+    const password = "123bB45%";
    // Act
    const result = isValidPassword(password);
    // Assert
    expect(result).toEqual(true);
 }
-);
+);
+test("password has at least one uppercase letter (A-Z)", () => {
+  const password = "abcB123%"; 
+  const result = isValidPassword(password);
+  expect(result).toEqual(true);
+});
+test("password has at least one lowercase letter (a-z)", () => {
+  const password = "abcB123%";
+  const result = isValidPassword(password);
+  expect(result).toEqual(true);
+});
+test("password has at least one number (0-9)", () => {
+  const password = "abcB123%";
+  const result = isValidPassword(password);
+  expect(result).toEqual(true);
+});
+test('password has at least one of the following non-alphanumeric symbols: ("!", "#", "$", "%", ".", "*", "&")', () => {
+  const password = "abcB123%";
+  const result = isValidPassword(password);
+  expect(result).toEqual(true);
+});


All these tests should also check if the function can return false when the password satisfies all other conditions except the one described in the test.

For example,

test("password has at least 5 characters", () => { // This password contains each of the required characters but is too short expect( isValidPassword("Aa1$") ).toEqual(false); }

alexandru-pocovnicu · 2025-07-16T17:43:43Z

Hi, I don't know what's happening, all the files in sprint 3 from my computer are empty, as if i haven't done any work in them , is there a way I could copy the ones on github, should i clone the whole PR and then push that , will i have to create a new PR?
Thank you.

alexandru-pocovnicu · 2025-07-16T18:05:43Z

never mind the previous message , sorted....i was in the wrong branch

alexandru-pocovnicu added 18 commits June 16, 2025 17:00

d

301ccc0

i have written the test and completed the code accordingly

aee8b64

created the tests and added new lines of code

76d10a5

wrote assertions and completed the code accordingly

ae4f944

replaced the comments with jest test cases

e282ccf

added the completed function

d81fcbb

CREATED TEST CASES FOR THE FUNCTION

777b1e7

replaced code with mine

9dcbdca

written all the test cases, all passed

02ba073

replaced with my code

7aab1ad

wrote the second test

5eb2d42

updated the code

743ea0a

implemented and tested additional cases

cabdf43

updated the code to cover the test cases

5889529

wrote the test cases

244fe2e

updated the code according to the test cases

3b0d529

wrote the test cases

66ab144

wrote the code according to test cases

93f777e

alexandru-pocovnicu added the Needs Review Participant to add when requesting review label Jul 4, 2025

alexandru-pocovnicu changed the title ~~Coursework/sprint 3~~ London|May 2025|Alexandru Pocovnicu|Coursework/sprint 3 Jul 5, 2025

illicitonion mentioned this pull request Jul 15, 2025

London|May-2025|Alexandru Pocovnicu|Coursework|sprint 3 #570

Closed

5 tasks

cjyuan added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Participant to add when requesting review labels Jul 15, 2025

cjyuan reviewed Jul 15, 2025

View reviewed changes

cjyuan added Reviewed Volunteer to add when completing a review and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Jul 15, 2025

alexandru-pocovnicu added 2 commits July 16, 2025 21:55

adjusted tests and code according to review

9e994f7

added a few more tests for edge cases

46128d9

simplified the code by adding else

dd284bc

		if (rank === "A") return 11;
		if(rank>=2 && rank<10)return Number(rank);

Uh oh!

London|May 2025|Alexandru Pocovnicu|Coursework/sprint 3 #639

Are you sure you want to change the base?

London|May 2025|Alexandru Pocovnicu|Coursework/sprint 3 #639

Conversation

alexandru-pocovnicu commented Jul 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Learners, PR Template

Changelist

Questions

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

alexandru-pocovnicu commented Jul 16, 2025

Uh oh!

alexandru-pocovnicu commented Jul 16, 2025

Uh oh!

Uh oh!

alexandru-pocovnicu commented Jul 4, 2025 •

edited

Loading