Sheffield | May-2025 | Declan Williams | Sprint-3 #623

CatchingKiyoko · 2025-06-28T14:08:51Z

Learners, PR Template

Self checklist

I have committed my files one by one, on purpose, and for a reason
I have titled my PR with REGION | COHORT_NAME | FIRST_NAME LAST_NAME | PROJ_NAME
I have tested my changes
My changes follow the style guide
My changes meet the requirements of this task

Changelist

Implemented changes and fixes to files.
added comments detailing ,explaining code and answered questions with comments.
refactored some lines to make neater and easier to read.
added tests with jest.

Briefly explain your PR.

Questions

Ask any questions you have for your reviewer.

… corresponding test case

…angles in getAngleType function

…d corresponding test case

…add corresponding test case

…d corresponding test case

…CardValue function with comments explaining function and updated tests

…ction and add corresponding test cases

…alid card ranks

…alue function

…tion

…al suffixes

…function

…lNumber function

…function

…test for special ordinal numbers

…comments detailing.

cjyuan · 2025-07-03T12:38:44Z

Sprint-3/2-mandatory-rewrite/1-get-angle-type.js

+  if (angle < 90)
+    return "Acute angle";
+  if ((angle > 90) && (angle < 180))
+    return "Obtuse angle";
+  if (angle === 180)
+    return "Straight angle";
+  if ((angle > 180) && (angle < 360))
+    return "Reflex angle";
 }


Your function can return undefined for some values of angle. To ensure reliability, please update the function so it always returns a defined value (which can be "Invalid angle") or throws an error. Functions that are expected to return a result should never return undefined.

Note: the spec fails to mention angles <= 0 are not "Acute angle".

addressed the problem about returning undefined for some angle values and to handle invalid inputs explicitly, I’ve added this validation check to return Invalid angle in these cases

cjyuan · 2025-07-03T12:52:12Z

Sprint-3/2-mandatory-rewrite/2-is-proper-fraction.js

In mathematics, -4/7 == 4/-7, and -4/-7 == 4/7.
So, ideally isProperFraction() should recognise all of them as proper fractions.

Similarly, -5/2 == 5/-2, and -5/-2 == 5/2.
So isProperFraction(-5, 2) should also return false because -5/2 is not a proper fraction. (Currently your function return true)

Hint: we can compare the absolute value of both parameters instead.

fixed the logic to handle division by zero and simplify return statement to correct the issues

…mplify return statement

cjyuan

Changes look good! Well done.

cjyuan · 2025-07-18T15:39:26Z

Sprint-3/2-mandatory-rewrite/2-is-proper-fraction.js

+    if (denominator === 0) return false; // avoid division by zero
+    return Math.abs(numerator) < Math.abs(denominator);


The condition at line 3 could also take case of cases where denominator is 0.

cjyuan · 2025-07-18T15:40:45Z

Sprint-3/2-mandatory-rewrite/1-get-angle-type.js

@@ -1,4 +1,6 @@
 function getAngleType(angle) {
+if (typeof angle !== "number" || angle <= 0 || angle > 360) return "Invalid angle";


This is good.
Since NaN is also of type "number", you could also consider rejecting NaN.

CatchingKiyoko added 30 commits June 17, 2025 19:19

Implement acute angle identification in getAngleType function and add…

be25f2c

… corresponding test case

Fix syntax error in acute angle test case

4fa86db

Implement angle type identification for obtuse, straight, and reflex …

d317d4f

…angles in getAngleType function

Add tests for identifying obtuse angles in getAngleType function

dea34f8

Add test cases for identifying reflex angles in getAngleType function

952fd14

Implement acute angle identification in getAngleType function

8cf3f58

Implement obtuse angle identification in getAngleType function and ad…

6da0615

…d corresponding test case

Implement straight angle identification in getAngleType function and …

45209eb

…add corresponding test case

Implement reflex angle identification in getAngleType function and ad…

37f345d

…d corresponding test case

Implement card value retrieval for face cards and number cards in get…

ed4eaf3

…CardValue function with comments explaining function and updated tests

Implement numerical value retrieval for cards 2-9 in getCardValue fun…

a0d4fcf

…ction and add corresponding test cases

Enhance getCardValue function comments and add error handling for inv…

d32c392

…alid card ranks

Fix typo in error message assertion for invalid card rank in getCardV…

e7f3d74

…alue function

Implement card value retrieval for all ranks in getCardValue function

2e2d63c

Add tests for number card values 2-10 in getCardValue function

900385e

Add tests for face cards (J, Q, K) in getCardValue function

67c92c2

add tests for handling Aces in getCardValue function

60ed74f

fix: correct expect statement for Ace value in getCardValue tests

bcdba1c

add test for handling invalid card ranks in getCardValue function

a16c211

refactor: implement character counting logic in countChar function

aced4d1

add test for handling no occurrences of a character in countChar func…

0a913b0

…tion

refactor: implement getOrdinalNumber function to return correct ordin…

de7632b

…al suffixes

reimplmented module.exports for jest tests

aa7b3ee

fix: correct ordinal suffix casing in getOrdinalNumber function

d2a8646

refactor: remove console.log statements from getOrdinalNumber function

9798ed9

test: add test cases for ordinal numbers 2 and 3 in getOrdinalNumber …

63a66e2

…function

test: enhance test cases for ordinal numbers 1, 2, and 3 in getOrdina…

c89c3b8

…lNumber function

fix: correct conditional check for special cases in getOrdinalNumber …

2b44bf7

…function

test: update test descriptions for ordinal numbers and implemented a …

df5287d

…test for special ordinal numbers

implemented repeat function with error handling and edge cases with …

1f02ed6

…comments detailing.

CatchingKiyoko added 10 commits June 28, 2025 12:01

fix: correct typo in error message for negative count in repeat function

900db99

refactor: comment out console log examples in repeat function

5d2265b

test: add test case for returning original string when count is 1

525641a

test: add test case for handling count of 0 in repeat function

4f81c7d

test: add test case for handling negative count in repeat function

d34ba19

fix: add missing assertions for negative and equal fraction checks

dd38ca5

fix: clarify return statement in isProperFraction function

5798163

test: add missing test case for improper fraction

a8d9ac3

test: add missing test case for negative fraction

1a34fcf

test: add missing test case for equal fraction

c5d4342

CatchingKiyoko linked an issue Jun 28, 2025 that may be closed by this pull request

02 Complete Sprint 3 coursework CatchingKiyoko/My-Coursework-Planner#21

Open

CatchingKiyoko added 📅 Sprint 3 Assigned during Sprint 3 of this module Needs Review Participant to add when requesting review labels Jun 28, 2025

cjyuan reviewed Jul 3, 2025

View reviewed changes

cjyuan added Reviewed Volunteer to add when completing a review and removed Needs Review Participant to add when requesting review labels Jul 3, 2025

CatchingKiyoko added 2 commits July 18, 2025 01:26

fix: add input validation for angle in getAngleType function

e4b3cf0

fix: updated isProperFraction logic to handle division by zero and si…

885b7d5

…mplify return statement

CatchingKiyoko added Needs Review Participant to add when requesting review and removed Reviewed Volunteer to add when completing a review labels Jul 18, 2025

cjyuan reviewed Jul 18, 2025

View reviewed changes

cjyuan added Complete Volunteer to add when work is complete and review comments have been addressed and removed Needs Review Participant to add when requesting review labels Jul 18, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Sheffield | May-2025 | Declan Williams | Sprint-3 #623

Sheffield | May-2025 | Declan Williams | Sprint-3 #623

CatchingKiyoko commented Jun 28, 2025

Uh oh!

cjyuan Jul 3, 2025

Uh oh!

CatchingKiyoko Jul 18, 2025

Uh oh!

cjyuan Jul 3, 2025

Uh oh!

CatchingKiyoko Jul 18, 2025

Uh oh!

cjyuan left a comment

Uh oh!

cjyuan Jul 18, 2025

Uh oh!

cjyuan Jul 18, 2025

Uh oh!

Uh oh!

		if (denominator === 0) return false; // avoid division by zero
		return Math.abs(numerator) < Math.abs(denominator);

		@@ -1,4 +1,6 @@
		function getAngleType(angle) {
		if (typeof angle !== "number" \|\| angle <= 0 \|\| angle > 360) return "Invalid angle";

Uh oh!

Sheffield | May-2025 | Declan Williams | Sprint-3 #623

Are you sure you want to change the base?

Sheffield | May-2025 | Declan Williams | Sprint-3 #623

Conversation

CatchingKiyoko commented Jun 28, 2025

Learners, PR Template

Changelist

Questions

Uh oh!

cjyuan Jul 3, 2025

Choose a reason for hiding this comment

Uh oh!

CatchingKiyoko Jul 18, 2025

Choose a reason for hiding this comment

Uh oh!

cjyuan Jul 3, 2025

Choose a reason for hiding this comment

Uh oh!

CatchingKiyoko Jul 18, 2025

Choose a reason for hiding this comment

Uh oh!

cjyuan left a comment

Choose a reason for hiding this comment

Uh oh!

cjyuan Jul 18, 2025

Choose a reason for hiding this comment

Uh oh!

cjyuan Jul 18, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!