generated from CodeYourFuture/Module-Template
-
-
Notifications
You must be signed in to change notification settings - Fork 196
London | ITP-May-2025 | Seddiq Azam | Module-Structuring-and-Testing-Data | Sprint-3 #621
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sedazam
wants to merge
21
commits into
CodeYourFuture:main
Choose a base branch
from
sedazam:Sprint-3
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 15 commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
801370c
modified: Sprint-3/1-key-implement/1-get-angle-type.js
sedazam 783668e
modified: Sprint-3/1-key-implement/1-get-angle-type.js
sedazam 38f709c
modified: Sprint-3/1-key-implement/2-is-proper-fraction.js
sedazam 639f8b3
modified: Sprint-3/1-key-implement/3-get-card-value.js
sedazam a226acb
modified: Sprint-3/1-key-implement/2-is-proper-fraction.js
sedazam 7d6581e
modified: Sprint-3/2-mandatory-rewrite/1-get-angle-type.js
sedazam d7205b2
modified: Sprint-3/2-mandatory-rewrite/1-get-angle-type.test.js
sedazam 59f3d57
modified: Sprint-3/2-mandatory-rewrite/1-get-angle-type.js
sedazam 2c59948
modified: Sprint-3/2-mandatory-rewrite/1-get-angle-type.test.js
sedazam 9e9c806
modified: Sprint-3/2-mandatory-rewrite/2-is-proper-fraction.js
sedazam 7d1152b
modified: Sprint-3/2-mandatory-rewrite/3-get-card-value.js
sedazam b3b9169
modified: Sprint-3/3-mandatory-practice/implement/count.js
sedazam ce039c5
modified: Sprint-3/3-mandatory-practice/implement/get-ordinal-numb…
sedazam 898a396
modified: Sprint-3/3-mandatory-practice/implement/repeat.js
sedazam 9e4a1ce
modified: Sprint-3/2-mandatory-rewrite/3-get-card-value.test.js
sedazam 37aea1b
modified: Changes made if angles are <0 or >360 must return invalid …
sedazam 84dbda7
modified: Changed parseInt to Number(str) Sprint-3/2-mandatory-rewr…
sedazam a62c043
modified: Sprint-3/3-mandatory-practice/implement/get-ordinal-numb…
sedazam 8d1a9d8
modified: Updated the test description Sprint-3/3-mandatory-practice…
sedazam 0ccc994
modified: Fixed isProperFraction(-2, 3) should return true Sprint-…
sedazam f6376ea
modified: Sprint-3/2-mandatory-rewrite/3-get-card-value.js
sedazam File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,18 +1,18 @@ | ||
function getAngleType(angle) { | ||
if (angle === 90) return "Right angle"; | ||
if (angle < 90) return "Acute angle"; | ||
if (angle > 90 && angle < 180) return "Obtuse angle"; | ||
if (angle === 180) return "Straight angle"; | ||
if (angle > 180 && angle < 360) return "Reflex angle"; | ||
// replace with your completed function from key-implement | ||
|
||
} | ||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
// Don't get bogged down in this detail | ||
// Jest uses CommonJS module syntax by default as it's quite old | ||
// We will upgrade our approach to ES6 modules in the next course module, so for now | ||
// We will upgrade our approach to ES6 modules in the next course module, so for now | ||
// we have just written the CommonJS module.exports syntax for you | ||
module.exports = getAngleType; | ||
module.exports = getAngleType; | ||
|
||
// [Running] node "/Users/seddiqazam/Documents/CYF/Module-Structuring-and-Testing-Data/Sprint-3/2-mandatory-rewrite/1-get-angle-type.js" | ||
|
||
// [Done] exited with code=0 in 0.051 seconds |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.