West Midland | ITP-May-2025 | Saleh Yousef | Module-Structuring-and-Testing-Data | sprint 2 #589
+115
−42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
new file: prep/example.js
…ent toPounds function, and enhance formatAs12HourClock function with tests
SalehOmar-Y
added
📅 Sprint 2
SalehOmar-Y
changed the title
LonMcGregor
added
Review in progress
LonMcGregor
reviewed
Jul 4, 2025
There was a problem hiding this comment.
Good solutions to this sprint. I've left one comment for you to reply to, which is very minor. Everything else looks good.
Remember to take care to only commit files that are relevant to what you're working on - maybe you did not need to commit the "prep" directory.
Sprint-2/2-mandatory-debug/1.js
Outdated
| // Finally, correct the code to fix the problem | ||
| // =============> write your new code here | ||
| function sum(a, b) { | ||
| return result = | ||
| a + b; |
There was a problem hiding this comment.
This works, can you see any way you could clean the code up so it is easier to read?
There was a problem hiding this comment.
I've taken return result = a + b; off as it the same as return a + b that’s better. Thank you
LonMcGregor
added
Reviewed
SalehOmar-Y
added
Needs Review
|
Could you please review the PR, this from last week and i’ve made the
change as mentioned. Thank you
…On Fri, 4 Jul 2025 at 11:39 AM LonMcGregor ***@***.***> wrote:
***@***.**** commented on this pull request.
Good solutions to this sprint. I've left one comment for you to reply to,
which is very minor. Everything else looks good.
Remember to take care to only commit files that are relevant to what
you're working on - maybe you did not need to commit the "prep" directory.
------------------------------
In Sprint-2/2-mandatory-debug/1.js
<#589 (comment)>
:
> // Finally, correct the code to fix the problem
// =============> write your new code here
+function sum(a, b) {
+ return result =
+ a + b;
This works, can you see any way you could clean the code up so it is
easier to read?
—
Reply to this email directly, view it on GitHub
<#589 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BR4U662RGI2JTKVVNJEOE3D3GZKUZAVCNFSM6AAAAAB73LLSL2VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDSOBWGU3DANZRGQ>
.
You are receiving this because you authored the thread.Message ID:
<CodeYourFuture/Module-Structuring-and-Testing-Data/pull/589/review/2986560714
@github.com>
|
added 2 commits
July 12, 2025 14:40
|
Everything looks good now, good job @SalehOmar-Y |
oluwatunmiisheii
added
Complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Briefly explain your PR.
This pull request includes all required changes for Sprint 2, such as implementing new features and functions, fixing bugs from the previous sprint, improving code structure and readability, updating and adding relevant test cases, and refactoring functions for better performance and maintainability
Questions
Ask any questions you have for your reviewer.