Skip to content

London | May 2025 | Halimatou Saddiyaa | Module-Structuring-and-Testing-Data | Sprint 2 #575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

Halimatou-saddiyaa
Copy link

Learners, PR Template

Self checklist

  • I have committed my files one by one, on purpose, and for a reason
  • I have titled my PR with REGION | COHORT_NAME | FIRST_NAME LAST_NAME | PROJ_NAME
  • I have tested my changes
  • My changes follow the style guide
  • My changes meet the requirements of this task

Changelist

I've completed the following tasks:

  • 1 key errors
  • 2 mandatory debug
  • 3 mandatory implement
  • 4 mandatory interpret

Please review my PR

Questions

Ask any questions you have for your reviewer.

@Halimatou-saddiyaa Halimatou-saddiyaa added 📅 Sprint 2 Assigned during Sprint 2 of this module Needs Review Participant to add when requesting review labels Jun 19, 2025
Comment on lines 20 to 21
return bmi.toFixed(1);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What type of value do you expect the function to return? A number or a string?
Does your function return the type of value you expect it to return?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was expecting the value to return a number, but after checking with the typeof operator, I can see that it returns a string. I need to use the parsefloat function to make sure that the string converts to a number. I've corrected it on my code.

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review and removed Needs Review Participant to add when requesting review labels Jul 3, 2025
@Halimatou-saddiyaa Halimatou-saddiyaa added Needs Review Participant to add when requesting review and removed Reviewed Volunteer to add when completing a review labels Jul 3, 2025
@cjyuan
Copy link
Contributor

cjyuan commented Jul 3, 2025

Changes look good. Well done.

@cjyuan cjyuan added Complete Volunteer to add when work is complete and review comments have been addressed and removed Needs Review Participant to add when requesting review labels Jul 3, 2025
@Halimatou-saddiyaa
Copy link
Author

Thank you for reviewing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complete Volunteer to add when work is complete and review comments have been addressed 📅 Sprint 2 Assigned during Sprint 2 of this module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants