-
-
Notifications
You must be signed in to change notification settings - Fork 195
London | May 2025 | Halimatou Saddiyaa | Module-Structuring-and-Testing-Data | Sprint 2 #575
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
London | May 2025 | Halimatou Saddiyaa | Module-Structuring-and-Testing-Data | Sprint 2 #575
Conversation
return bmi.toFixed(1); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What type of value do you expect the function to return? A number or a string?
Does your function return the type of value you expect it to return?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was expecting the value to return a number, but after checking with the typeof operator, I can see that it returns a string. I need to use the parsefloat function to make sure that the string converts to a number. I've corrected it on my code.
Changes look good. Well done. |
Thank you for reviewing! |
Learners, PR Template
Self checklist
Changelist
I've completed the following tasks:
Please review my PR
Questions
Ask any questions you have for your reviewer.