Skip to content

Glasgow | May-2025 | Adiyah Farhan | Sprint-3 #573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

Glasgow | May-2025 | Adiyah Farhan | Sprint-3 #573

wants to merge 14 commits into from

Conversation

AdiyahFarhan
Copy link

Learners, PR Template

Self checklist

  • I have committed my files one by one, on purpose, and for a reason
  • I have titled my PR with REGION | COHORT_NAME | FIRST_NAME LAST_NAME | PROJ_NAME
  • I have tested my changes
  • My changes follow the style guide
  • My changes meet the requirements of this task

Changelist

Files from the following folders
1-key-implement
2-mandatory-rewrite
3-mandatory practice/implement
has been updated/implemented as per the requirements.
One file passwordValidator from 4-stretch-investigate has implemented.

Questions

Not yet

@AdiyahFarhan
Exercise 1-key-implement done
35aa2c9
@AdiyahFarhan
code from ./1-key-implement/1-get-angle-type copied in file ./2-manda…
859b4f5 
…tory-rewrite/1-get-angle -type.js
@AdiyahFarhan
Test has been written in file ./2-mandatory-rewrite/1-get-angle-type.…
6045882 
…test.js using Jest.
@AdiyahFarhan
Added completed function from ./1-key-implement/2-is-proper-fraction.js
b93ece9
@AdiyahFarhan
Write Test for different cases in 2-is-proper-fraction.test.js by usi…
b35f735 
…ng Jest
@AdiyahFarhan
Added code from ./1-key implement/3-get-card-value.js
5dac570
@AdiyahFarhan
Write test for the possible cases in 3-get-card-c-value.test.js
65c49be
@AdiyahFarhan
Implements the function countChar() to find the requested char in the…
fd402ee 
… string, and tested it for different test cases with jest
@AdiyahFarhan
Implement the function getOrdinalNumber() to convert the number into …
9a056c0 
…ordinal, also tested it with different test cases in jest
@AdiyahFarhan
The function repeat() has been implemented and tested for all the pos…
d9099ed 
…sible test cases with jest
@AdiyahFarhan
Function passwordValidator has been implemented to check for the vali…
36327a5 
…d password and tested for each case using jest
@AdiyahFarhan AdiyahFarhan added Needs Review Participant to add when requesting review 📅 Sprint 3 Assigned during Sprint 3 of this module labels Jun 18, 2025
@LonMcGregor LonMcGregor added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Participant to add when requesting review labels Jul 2, 2025
LonMcGregor
LonMcGregor reviewed Jul 2, 2025
View reviewed changes
Copy link

@LonMcGregor LonMcGregor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, very well done. You've written good solutions and good test cases. I have left a couple of comments for some of them for you to take a look at.

Sprint-3/1-key-implement/2-is-proper-fraction.js
if (numerator < denominator) return true;
if (Math.abs(numerator) < denominator) return true;
else if (Math.abs(numerator) > denominator) return false;
else return false;
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you see any way you could remove the extra else branch here?

Sprint-3/1-key-implement/3-get-card-value.js Outdated
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this work when the card value is 10?

Sprint-3/3-mandatory-practice/implement/repeat.js Outdated
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a matter of practice, you might consider implementing repeat() yourself, rather than using the built-in string .repeat() function

@LonMcGregor LonMcGregor added Reviewed Volunteer to add when completing a review and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Jul 2, 2025
@AdiyahFarhan
Copy link
Author

AdiyahFarhan commented Jul 7, 2025 •
edited
Loading

Overall, very well done. You've written good solutions and good test cases. I have left a couple of comments for some of them for you to take a look at.

Thank you @LonMcGregor for taking the time to review my pull request and provide valuable suggestions. I have implemented the recommended changes and committed them to the respective files. Kindly review the updates at your convenience.

@AdiyahFarhan AdiyahFarhan added Needs Review Participant to add when requesting review and removed Reviewed Volunteer to add when completing a review labels Jul 7, 2025
@AdiyahFarhan AdiyahFarhan mentioned this pull request Jul 11, 2025
Open
@LonMcGregor
Copy link

Hi adiyah, you've correctly identified the ways to improve your solution, and good job doing the full repeat implementation. This sprint is complete now, you can close it and move to the next

@LonMcGregor LonMcGregor added Complete Volunteer to add when work is complete and review comments have been addressed and removed Needs Review Participant to add when requesting review labels Jul 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LonMcGregor LonMcGregor LonMcGregor left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Complete Volunteer to add when work is complete and review comments have been addressed 📅 Sprint 3 Assigned during Sprint 3 of this module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AdiyahFarhan @LonMcGregor