Skip to content

Sheffield | May-2025 | Declan Williams | Sprint-2 #565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 17 commits into
base: main
Choose a base branch
from
Open

Sheffield | May-2025 | Declan Williams | Sprint-2 #565

wants to merge 17 commits into from

Conversation

CatchingKiyoko
Copy link

Learners, PR Template

Self checklist

  • I have committed my files one by one, on purpose, and for a reason
  • I have titled my PR with REGION | COHORT_NAME | FIRST_NAME LAST_NAME | PROJ_NAME
  • I have tested my changes
  • My changes follow the style guide
  • My changes meet the requirements of this task

Changelist

  1. made changes to sections of code for implementation, debugging and error fixes
  2. updated comments to answer questions in the sprint sections

Briefly explain your PR.

Questions

Ask any questions you have for your reviewer.

@CatchingKiyoko
fix: resolve variable redeclaration error in capitalize function
4cb9354
@CatchingKiyoko
fix: comment out erroneous capitalize function to prevent redeclarati…
2fafe6e 
…on error so that new code will work correctly and not throw the old error
@CatchingKiyoko
fix: correct parameter name in square function to prevent syntax erro…
7620265 
…r and update console log example
@CatchingKiyoko
fix: add console log for square function with example input and corre…
071cf21 
…cted error missing )
@CatchingKiyoko
update comments to clarify expected output and explanation in getLast…
c1c09a6 
…Digit function
@CatchingKiyoko
fix: correct getLastDigit function to accept parameters and return th…
e72b13a 
…e last digit of input numbers
@CatchingKiyoko
fix: update explanation for getLastDigit function to clarify paramete…
832d9bb 
…r usage
@CatchingKiyoko
explained in comments why errors occured and then refactored the code…
2a18e2c 
… to fix the convert to percentage function works correctly
@CatchingKiyoko
fix: update multiply function to return the product instead of loggin…
dde5917 
…g it and updated comments
@CatchingKiyoko
fix: correct sum function to return the sum of two numbers and update…
fdf492e 
… comments for clarity
@CatchingKiyoko
feat: implement BMI calculation function and add example usage
48d2e3a
@CatchingKiyoko
feat: implement toUpperSnakeCase function to convert strings to UPPER…
e2c65bf 
…_SNAKE_CASE
@CatchingKiyoko
feat: implement toPounds function to convert pence strings to pounds …
bb731c1 
…format with example usage
@CatchingKiyoko
fix: add console log and comments for clarity in formatTimeDisplay fu…
8c166ff 
…nction
@CatchingKiyoko CatchingKiyoko added 📅 Sprint 2 Assigned during Sprint 2 of this module Needs Review Participant to add when requesting review labels Jun 17, 2025
@CatchingKiyoko CatchingKiyoko linked an issue Jun 17, 2025 that may be closed by this pull request
02 Complete Sprint 2 coursework CatchingKiyoko/My-Coursework-Planner#19
Open
cjyuan
cjyuan reviewed Jun 27, 2025
View reviewed changes
@cjyuan cjyuan added Reviewed Volunteer to add when completing a review and removed Needs Review Participant to add when requesting review labels Jun 27, 2025
@CatchingKiyoko
Update 1-bmi.js
2f41d57 
updated comments for clarity on roundedBmi returning as a string.
@CatchingKiyoko
Update 2-cases.js
d04b7bd 
refactored code to be indented properly.
and updated name of function to align more correctly with the values of the variable stored.
@CatchingKiyoko CatchingKiyoko added Needs Review Participant to add when requesting review and removed Reviewed Volunteer to add when completing a review labels Jun 28, 2025
@cjyuan
Copy link
Contributor

cjyuan commented Jun 29, 2025

Changes look good! Good job!

@cjyuan cjyuan added Complete Volunteer to add when work is complete and review comments have been addressed and removed Needs Review Participant to add when requesting review labels Jun 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjyuan cjyuan cjyuan left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Complete Volunteer to add when work is complete and review comments have been addressed 📅 Sprint 2 Assigned during Sprint 2 of this module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

02 Complete Sprint 2 coursework
2 participants
@CatchingKiyoko @cjyuan