London | ITP-May-2025 | Seddiq Azam | Module-Structuring-and-Testing-Data | Sprint-2

[sedazam]

This pull request focuses on debugging and improving JavaScript functions in various files under the Sprint-2 directory. The changes address syntax errors, logical errors, and implementation of new functionality. Below is a summary of the most important changes grouped by theme:

Debugging and Fixing Syntax/Logical Errors:

• Fixed redeclaration issues in capitalise function: Removed let from the function to allow modification of the existing str variable.
• Corrected convertToPercentage function: Resolved variable scope issues by defining decimalNumber outside the function and passing it as an argument.
• Fixed parameter and return issues in square function: Changed the invalid parameter 3 to num and ensured proper function calls.
• Fixed missing return statement in multiply function: Added a return statement to allow the function to return the multiplication result instead of logging it.
• Removed unnecessary semicolon in sum function: Eliminated a semicolon that was preventing the function from executing properly.

Debugging Issues with Global Variables:

• Revised getLastDigit function: Updated the function to accept a parameter instead of relying on a fixed global variable, ensuring correct outputs for different inputs.

Implementing New Functionality:

• Implemented calculateBMI function: Added a function to calculate BMI with weight and height, formatted to one decimal place.
• Added toUpperSnakeCase function: Created a function to convert strings to uppercase and replace spaces with underscores.
• Implemented toPounds function: Added a function to convert a pence string (e.g., "399p") into a formatted pounds string (e.g., "£3.99").

Interpretation and Explanation of Existing Code:

• Analyzed formatTimeDisplay function: Provided detailed answers on how the pad function is called and its behavior during time formatting.

These changes collectively improve the codebase by fixing errors, enhancing functionality, and ensuring clarity in explanations and implementations.<!--

You must title your PR like this:

REGION | COHORT_NAME | FIRST_NAME LAST_NAME | PROJ_NAME

For example,

London | May-2025 | Carol Owen | Sprint-1

Complete the task list below this message.
If your PR is rejected, check the task list.

-->

Learners, PR Template

Self checklist

• I have committed my files one by one, on purpose, and for a reason
• I have titled my PR with REGION | COHORT_NAME | FIRST_NAME LAST_NAME | PROJ_NAME
• I have tested my changes
• My changes follow the style guide
• My changes meet the requirements of this task

Changelist

Briefly explain your PR.

In this PR, you will see the necessary changes made and questions answered for Sprint 2.
This request also includes multiple improvements and the implementation of various functions related to JavaScript fundamentals.

Questions

Ask any questions you have for your reviewer.

[cjyuan]

Code looks good. No chance required.