London | May-2025 | Reza Jahanimir | Coursework/sprint 2 #524
Conversation
Reza-Jahanimir
added
Needs Review
Sprint-2/1-key-errors/0.js
Outdated
|
|
||
| function capitalise(str) { | ||
| let cap_string = `${str[0].toUpperCase()}${str.slice(1)}`; | ||
| return cap_string; | ||
| }; |
There was a problem hiding this comment.
Great solution on this question, but remember that if a variable will not be reassigned after it has been declared, then it should be a const, only use let if you believe that the variable will change later on
|
|
||
| // =============> explain this error message here | ||
| // First Two Lines: Locate the file path and the specific line of code causing the error. | ||
| // Following Lines: Display the type of error (SyntaxError) and its message. |
There was a problem hiding this comment.
This is a simple and straight forward explanation, nice job
| return result; | ||
| } | ||
|
|
||
| console.log(`The result of multiplying 10 and 32 is ${multiply(10, 32)}`); |
There was a problem hiding this comment.
You provided the right solution here, with a simple suggestion.
The console.log in the function is not necessary, as you will notice that the final result will print out two results, the first is just the result, and the second will be the statement in line 24
| const height_squared = height * height; |
There was a problem hiding this comment.
Simple solutions that are simple to read are always good code, which you have done here. Just want to draw your attention to some built-in methods that JavaScript has for this same thing
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Math/pow
| } else if (hours > 12) { | ||
| return `${hours - 12} pm`; | ||
| } else { | ||
| return `${hours} am`; | ||
| } |
There was a problem hiding this comment.
Your solution is returning 12 pm when we expect to see 12:00 pm, for example.
You need to take a look at the original question again and see how you can do that 🙂
hokagedemehin
added
Review in progress
Reza-Jahanimir
added
Needs Review
| } | ||
| return `${time} am`; | ||
| // If you input "08:00" is allowed to pass | ||
| const paddedHour = hourStr.length === 2 && displayHour < 10 ? `0${displayHour}` : `${displayHour}`; |
There was a problem hiding this comment.
Nice work in formatting the hour it is returned. I have a resource that you might want to consider should you need to do this again in the future
hokagedemehin
added
Complete
Learners, PR Template
Self checklist
Changelist
tried to answer the questions and tests
Questions
Ask any questions you have for your reviewer.