-
-
Notifications
You must be signed in to change notification settings - Fork 195
LONDON | May-2025 | Aida Eslamimoghadam| Module-Structuring-and-Testing-Data | Sprint-2 #516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Can you backup your code in Sprint-2 branch and follow these instructions to fix your branch? Its a good chance to practice using git to rebase a branch. This instructions assume you had created a branch named In your case, Important:
1. Open Your Cloned Repository in VSCode and Start a Terminal in VSCode.VSCode will start the terminal in the top-level folder of the current project. 2. Switch to the branch you want to rebase (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your code is well written.
Please fix the branch. :)
for (let i = 0; i < 5; i++) { | ||
let randomNumber = Math.floor(Math.random() * 100001); | ||
|
||
PenceRandom = randomNumber + "p"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not declare the variable and start its name with a lowercase letter?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Cj,
Thank you for your review.
I am trying to fix this issu. I learnt CamelCase incorrectly and I know it use for build-in function.
sorry about it.
I also fixed Branch issu.
Many thanks
Aida
Well done! |
Self checklist
Changelist:
UPDATE
Fixed issue. Branch is correct now.