-
-
Notifications
You must be signed in to change notification settings - Fork 196
Glasgow | May-2025 | Adiyah Farhan | Sprint-2 #515
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
395eced
d289941
2330e68
6c148b5
2cc6615
3909fbd
07f4d37
ca7399e
a1fc7bf
f9fdda6
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,13 +1,30 @@ | ||
// Predict and explain first... | ||
// =============> write your prediction here | ||
// I am unable to predict the error right now. | ||
|
||
// call the function capitalise with a string input | ||
// interpret the error message and figure out why an error is occurring | ||
|
||
function capitalise(str) { | ||
/*function capitalise(str) { | ||
let str = `${str[0].toUpperCase()}${str.slice(1)}`; | ||
return str; | ||
} | ||
|
||
output = capitalise("my name is adiyah"); | ||
console.log(output);*/ | ||
|
||
// =============> write your explanation here | ||
|
||
/* SyntaxError: Identifier 'str' has already been declared. | ||
This error occurs because the function parameter name and the variable name declared inside | ||
the function is same. This error can be fixed by either changing the parameter name or the variable name. | ||
*/ | ||
// =============> write your new code here | ||
|
||
function capitalize(str) { | ||
let inputStr = `${str[0].toUpperCase()}${str.slice(1)}`; | ||
return inputStr; | ||
} | ||
|
||
let output = capitalize("my name is Adiyah"); | ||
console.log(output); |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,20 +1,30 @@ | ||
|
||
// Predict and explain first BEFORE you run any code... | ||
|
||
// this function should square any number but instead we're going to get an error | ||
|
||
// =============> write your prediction of the error here | ||
// The error occurs because we pass a number as a parameter instead of passing the variable | ||
// num which we return through the function. | ||
|
||
function square(3) { | ||
/*function square(3) { | ||
return num * num; | ||
} | ||
*/ | ||
|
||
// =============> write the error message here | ||
// SyntaxError: Unexpected number | ||
|
||
// =============> explain this error message here | ||
// It says the number pass through the parameter is not a valid argument | ||
// instead the variable must be used. | ||
|
||
// Finally, correct the code to fix the problem | ||
|
||
// =============> write your new code here | ||
|
||
function square(num) { | ||
return num * num; | ||
} | ||
|
||
let result = square(3); | ||
console.log(result); |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,14 +1,24 @@ | ||
// Predict and explain first... | ||
|
||
// =============> write your prediction here | ||
// In line 10 the function 'multiply(a, b)' called which doesn't return any value. | ||
|
||
function multiply(a, b) { | ||
/*function multiply(a, b) { | ||
console.log(a * b); | ||
} | ||
|
||
console.log(`The result of multiplying 10 and 32 is ${multiply(10, 32)}`); | ||
*/ | ||
|
||
// =============> write your explanation here | ||
// The function should return a value for which we need to | ||
// replace the console.log() function with the return value | ||
|
||
// Finally, correct the code to fix the problem | ||
// =============> write your new code here | ||
|
||
function multiply(a, b) { | ||
return a * b; | ||
} | ||
|
||
console.log(`The result of multiplying 10 and 32 is ${multiply(10, 32)}`); |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,13 +1,22 @@ | ||
// Predict and explain first... | ||
// =============> write your prediction here | ||
// function doesn't return any value and print 'undefined' in console.log(). | ||
|
||
function sum(a, b) { | ||
/*function sum(a, b) { | ||
return; | ||
a + b; | ||
} | ||
|
||
console.log(`The sum of 10 and 32 is ${sum(10, 32)}`); | ||
console.log(`The sum of 10 and 32 is ${sum(10, 32)}`);*/ | ||
|
||
// =============> write your explanation here | ||
// The function first returns the value with is null and then the calculation takes place which doesn't return. | ||
|
||
// Finally, correct the code to fix the problem | ||
// =============> write your new code here | ||
|
||
function sum(a, b) { | ||
return a + b; | ||
} | ||
|
||
console.log(`The sum of 10 and 32 is ${sum(10, 32)}`); |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,8 +4,13 @@ | |
|
||
function formatAs12HourClock(time) { | ||
const hours = Number(time.slice(0, 2)); | ||
const minutes = time.slice(3, 5); | ||
if (hours > 12) { | ||
return `${hours - 12}:00 pm`; | ||
return `${hours - 12}:${minutes} pm`; | ||
} else if (hours == 0) { | ||
return `12:${minutes} am`; | ||
} else if (hours == 12) { | ||
return `${time} pm`; | ||
} | ||
return `${time} am`; | ||
} | ||
|
@@ -23,3 +28,24 @@ console.assert( | |
currentOutput2 === targetOutput2, | ||
`current output: ${currentOutput2}, target output: ${targetOutput2}` | ||
); | ||
|
||
const currentOutput3 = formatAs12HourClock("23:45"); | ||
const targetOutput3 = "11:45 pm"; | ||
console.assert( | ||
currentOutput3 === targetOutput3, | ||
`current output: ${currentOutput3}, target output: ${targetOutput3}` | ||
); | ||
Comment on lines
+31
to
+37
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can you add a few more test cases to test your function? In particulars, There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Two more test cases ("00:59" and "12:34") added to test the function. The function has been updated in order to pass all tests. |
||
|
||
const currentOutput4 = formatAs12HourClock("00:59"); | ||
const targetOutput4 = "12:59 am"; | ||
console.assert( | ||
currentOutput4 === targetOutput4, | ||
`current output: ${currentOutput4}, target output: ${targetOutput4}` | ||
); | ||
|
||
const currentOutput5 = formatAs12HourClock("12:34"); | ||
const targetOutput5 = "12:34 pm"; | ||
console.assert( | ||
currentOutput5 === targetOutput5, | ||
`current output: ${currentOutput5}, target output: ${targetOutput5}` | ||
); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: You could also keep the original global variable
decimalNumber
should you need to, even if it has the same name as the parameter. If you are interested in know why, you can look up "How JS resolve conflicting name".There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this valuable information.