Skip to content

Glasgow | May-2025 | Adiyah Farhan | Sprint-2 #515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 18 additions & 1 deletion Sprint-2/1-key-errors/0.js
Original file line number Diff line number Diff line change
@@ -1,13 +1,30 @@
// Predict and explain first...
// =============> write your prediction here
// I am unable to predict the error right now.

// call the function capitalise with a string input
// interpret the error message and figure out why an error is occurring

function capitalise(str) {
/*function capitalise(str) {
let str = `${str[0].toUpperCase()}${str.slice(1)}`;
return str;
}

output = capitalise("my name is adiyah");
console.log(output);*/

// =============> write your explanation here

/* SyntaxError: Identifier 'str' has already been declared.
This error occurs because the function parameter name and the variable name declared inside
the function is same. This error can be fixed by either changing the parameter name or the variable name.
*/
// =============> write your new code here

function capitalize(str) {
let inputStr = `${str[0].toUpperCase()}${str.slice(1)}`;
return inputStr;
}

let output = capitalize("my name is Adiyah");
console.log(output);
23 changes: 21 additions & 2 deletions Sprint-2/1-key-errors/1.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,19 +2,38 @@

// Why will an error occur when this program runs?
// =============> write your prediction here
/* Error will occur because the variable 'decimalNumber' declared inside the function and it should not
be passed as a parameter. Also variable decimalNumber is defined in the local scope and it cannot
be used in the global scope in 'console.log()'
*/

// Try playing computer with the example to work out what is going on

function convertToPercentage(decimalNumber) {
/*function convertToPercentage(decimalNumber) {
const decimalNumber = 0.5;
const percentage = `${decimalNumber * 100}%`;

return percentage;
}

console.log(decimalNumber);
console.log(decimalNumber);*/

// =============> write your explanation here
/* SyntaxError: Identifier 'decimalNumber' has already been declared occurs because
the same name is used for the parameter
*/
/* ReferenceError: decimalNumber is not defined occurs because it is defined inside the function and not
recognized in the global scope
*/

// Finally, correct the code to fix the problem
// =============> write your new code here

function convertToPercentage(decimalNumber) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: You could also keep the original global variable decimalNumber should you need to, even if it has the same name as the parameter. If you are interested in know why, you can look up "How JS resolve conflicting name".

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this valuable information.

const percentage = `${decimalNumber * 100}%`;

return percentage;
}

result = convertToPercentage(0.6);
console.log(result);
14 changes: 12 additions & 2 deletions Sprint-2/1-key-errors/2.js
Original file line number Diff line number Diff line change
@@ -1,20 +1,30 @@

// Predict and explain first BEFORE you run any code...

// this function should square any number but instead we're going to get an error

// =============> write your prediction of the error here
// The error occurs because we pass a number as a parameter instead of passing the variable
// num which we return through the function.

function square(3) {
/*function square(3) {
return num * num;
}
*/

// =============> write the error message here
// SyntaxError: Unexpected number

// =============> explain this error message here
// It says the number pass through the parameter is not a valid argument
// instead the variable must be used.

// Finally, correct the code to fix the problem

// =============> write your new code here

function square(num) {
return num * num;
}

let result = square(3);
console.log(result);
12 changes: 11 additions & 1 deletion Sprint-2/2-mandatory-debug/0.js
Original file line number Diff line number Diff line change
@@ -1,14 +1,24 @@
// Predict and explain first...

// =============> write your prediction here
// In line 10 the function 'multiply(a, b)' called which doesn't return any value.

function multiply(a, b) {
/*function multiply(a, b) {
console.log(a * b);
}

console.log(`The result of multiplying 10 and 32 is ${multiply(10, 32)}`);
*/

// =============> write your explanation here
// The function should return a value for which we need to
// replace the console.log() function with the return value

// Finally, correct the code to fix the problem
// =============> write your new code here

function multiply(a, b) {
return a * b;
}

console.log(`The result of multiplying 10 and 32 is ${multiply(10, 32)}`);
13 changes: 11 additions & 2 deletions Sprint-2/2-mandatory-debug/1.js
Original file line number Diff line number Diff line change
@@ -1,13 +1,22 @@
// Predict and explain first...
// =============> write your prediction here
// function doesn't return any value and print 'undefined' in console.log().

function sum(a, b) {
/*function sum(a, b) {
return;
a + b;
}

console.log(`The sum of 10 and 32 is ${sum(10, 32)}`);
console.log(`The sum of 10 and 32 is ${sum(10, 32)}`);*/

// =============> write your explanation here
// The function first returns the value with is null and then the calculation takes place which doesn't return.

// Finally, correct the code to fix the problem
// =============> write your new code here

function sum(a, b) {
return a + b;
}

console.log(`The sum of 10 and 32 is ${sum(10, 32)}`);
24 changes: 22 additions & 2 deletions Sprint-2/2-mandatory-debug/2.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,23 +2,43 @@

// Predict the output of the following code:
// =============> Write your prediction here
// Predicted Output:
// The last digit of 42 is 3
// The last digit of 105 is 3
// The last digit of 806 is 3

const num = 103;
/*const num = 103;

function getLastDigit() {
return num.toString().slice(-1);
}

console.log(`The last digit of 42 is ${getLastDigit(42)}`);
console.log(`The last digit of 105 is ${getLastDigit(105)}`);
console.log(`The last digit of 806 is ${getLastDigit(806)}`);
console.log(`The last digit of 806 is ${getLastDigit(806)}`);*/

// Now run the code and compare the output to your prediction
// =============> write the output here
// The last digit of 42 is 3
// The last digit of 105 is 3
// The last digit of 806 is 3

// Explain why the output is the way it is
// =============> write your explanation here
// Because it returns the value of the 'num' which is declared with the value '103'.
// And the function doesn't accept any parameters.

// Finally, correct the code to fix the problem
// =============> write your new code here

function getLastDigit(num) {
return num.toString().slice(-1);
}

console.log(`The last digit of 42 is ${getLastDigit(42)}`);
console.log(`The last digit of 105 is ${getLastDigit(105)}`);
console.log(`The last digit of 806 is ${getLastDigit(806)}`);

// This program should tell the user the last digit of each number.
// Explain why getLastDigit is not working properly - correct the problem
// The function doesn't work properly because the number wasn't pass as a parameter before.
12 changes: 10 additions & 2 deletions Sprint-2/3-mandatory-implement/1-bmi.js
Original file line number Diff line number Diff line change
Expand Up @@ -15,5 +15,13 @@
// It should return their Body Mass Index to 1 decimal place

function calculateBMI(weight, height) {
// return the BMI of someone based off their weight and height
}
// return the BMI of someone based off their weight and height
const heightSquare = height * height;
const BMI = weight / heightSquare;
const scaledBMI = BMI.toFixed(1);
return Number(scaledBMI);
}

result = calculateBMI(80, 1.89);
console.log(result);
//console.log(typeof calculateBMI());
9 changes: 9 additions & 0 deletions Sprint-2/3-mandatory-implement/2-cases.js
Original file line number Diff line number Diff line change
Expand Up @@ -14,3 +14,12 @@
// You will need to come up with an appropriate name for the function
// Use the MDN string documentation to help you find a solution
// This might help https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/toUpperCase

function convertUpper_snake_case(str) {
const caseConvert = str.toUpperCase();
const convertToSnakeCase = caseConvert.replaceAll(" ", "_");
return convertToSnakeCase;
}

const caseConverter = convertUpper_snake_case("lord of the rings");
console.log(caseConverter);
23 changes: 23 additions & 0 deletions Sprint-2/3-mandatory-implement/3-to-pounds.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,3 +4,26 @@
// You will need to declare a function called toPounds with an appropriately named parameter.

// You should call this function a number of times to check it works for different inputs

function convertToPounds(penceString) {
const penceStringWithoutTrailingP = penceString.substring(
0,
penceString.length - 1
);

const paddedPenceNumberString = penceStringWithoutTrailingP.padStart(3, "0");
const pounds = paddedPenceNumberString.substring(
0,
paddedPenceNumberString.length - 2
);

const pence = paddedPenceNumberString
.substring(paddedPenceNumberString.length - 2)
.padEnd(2, "0");

const convertAmount = "£" + pounds + "." + pence;
return convertAmount;
}

let convertedAmount = convertToPounds("450p");
console.log(convertedAmount);
10 changes: 5 additions & 5 deletions Sprint-2/4-mandatory-interpret/time-format.js
Original file line number Diff line number Diff line change
Expand Up @@ -17,18 +17,18 @@ function formatTimeDisplay(seconds) {
// Questions

// a) When formatTimeDisplay is called how many times will pad be called?
// =============> write your answer here
// 3 times

// Call formatTimeDisplay with an input of 61, now answer the following:

// b) What is the value assigned to num when pad is called for the first time?
// =============> write your answer here
// 0

// c) What is the return value of pad is called for the first time?
// =============> write your answer here
// "00"

// d) What is the value assigned to num when pad is called for the last time in this program? Explain your answer
// =============> write your answer here
// 1. num is assigned the value of remaining seconds.

// e) What is the return value assigned to num when pad is called for the last time in this program? Explain your answer
// =============> write your answer here
// 01. It padded the value to 2 digits.
28 changes: 27 additions & 1 deletion Sprint-2/5-stretch-extend/format-time.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,13 @@

function formatAs12HourClock(time) {
const hours = Number(time.slice(0, 2));
const minutes = time.slice(3, 5);
if (hours > 12) {
return `${hours - 12}:00 pm`;
return `${hours - 12}:${minutes} pm`;
} else if (hours == 0) {
return `12:${minutes} am`;
} else if (hours == 12) {
return `${time} pm`;
}
return `${time} am`;
}
Expand All @@ -23,3 +28,24 @@ console.assert(
currentOutput2 === targetOutput2,
`current output: ${currentOutput2}, target output: ${targetOutput2}`
);

const currentOutput3 = formatAs12HourClock("23:45");
const targetOutput3 = "11:45 pm";
console.assert(
currentOutput3 === targetOutput3,
`current output: ${currentOutput3}, target output: ${targetOutput3}`
);
Comment on lines +31 to +37
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a few more test cases to test your function? In particulars, "00:59", and "12:34".

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two more test cases ("00:59" and "12:34") added to test the function. The function has been updated in order to pass all tests.


const currentOutput4 = formatAs12HourClock("00:59");
const targetOutput4 = "12:59 am";
console.assert(
currentOutput4 === targetOutput4,
`current output: ${currentOutput4}, target output: ${targetOutput4}`
);

const currentOutput5 = formatAs12HourClock("12:34");
const targetOutput5 = "12:34 pm";
console.assert(
currentOutput5 === targetOutput5,
`current output: ${currentOutput5}, target output: ${targetOutput5}`
);