Skip to content

West Midlands | Alireza Seifi Shalamzari | Module-Structuring-and-Testing-Data:Sprint2-exercise | Week 2 #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

Alireza1620
Copy link

@Alireza1620 Alireza1620 commented Nov 18, 2024

Self checklist

  • I have committed my files one by one, on purpose, and for a reason
  • I have titled my PR with COHORT_NAME | FIRST_NAME LAST_NAME | REPO_NAME | WEEK
  • I have tested my changes
  • My changes follow the style guide
  • My changes meet the requirements of this task

Changelist

Completed Sprint 2 implementation exercises

Questions

@Alireza1620 Alireza1620 added the Needs Review Participant to add when requesting review label Nov 18, 2024
@Alireza1620 Alireza1620 requested review from SallyMcGrath and OracPrime and removed request for SallyMcGrath November 18, 2024 11:19
Copy link
Member

@SallyMcGrath SallyMcGrath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there @Alireza1620

It looks like you have made changes to files across different folders. Take a look https://github.com/CodeYourFuture/Module-Structuring-and-Testing-Data/pull/162/files

You need to make changes only to the relevant files in a PR, in this case it should be all the exercises in Sprint 2. Lots of people have trouble with this, so look in the questions channel on Slack to get help with fixing this. Good luck!

@SallyMcGrath SallyMcGrath added 👀 Review Git Changes requested to do with Git Reviewed Volunteer to add when completing a review and removed Needs Review Participant to add when requesting review labels Nov 18, 2024
@Alireza1620
Copy link
Author

Dear @SallyMcGrath
I actually found the problem!
I completed Sprint 1 and 2 but in different branches.
My mistake is when I tried to create a branch for Sprint 2, The branch was made based on Sprint 1 and not Main brach.
This PR is only to demonstrate Sprint 2 work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
👀 Review Git Changes requested to do with Git Reviewed Volunteer to add when completing a review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants