generated from CodeYourFuture/Module-Template
-
-
Notifications
You must be signed in to change notification settings - Fork 268
London | May-2025 | Victoria Scott | Form edits #707
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
VictoriaScottCodes
wants to merge
11
commits into
CodeYourFuture:main
Choose a base branch
from
VictoriaScottCodes:Form-edits
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 4 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
3afdf06
changes to titles, summary text and links
VictoriaScottCodes af59d19
included description
VictoriaScottCodes db13e2e
wireframe edits
VictoriaScottCodes f6581cc
Edited spacing and labels
VictoriaScottCodes 033815e
Removing trailing slashes and stray end tags
VictoriaScottCodes d9db3df
aligning image of article 2 and 3
VictoriaScottCodes 4bb98d9
CSS deleted & breaks added
VictoriaScottCodes 5367d83
added stricter validation rule using the pattern attribute
VictoriaScottCodes 1b55493
removed trailing slashes, edited main role from element, added missin…
VictoriaScottCodes 01ef41e
improved spacing and structure for 100% Accessibility
VictoriaScottCodes fd459ef
removed unrelated code to implement form. Reverted READ ME, CSS and h…
VictoriaScottCodes File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,27 +1,106 @@ | ||
<!DOCTYPE html> | ||
<html lang="en"> | ||
<head> | ||
<meta charset="utf-8" /> | ||
<meta http-equiv="X-UA-Compatible" content="IE=edge" /> | ||
<title>My form exercise</title> | ||
<meta name="description" content="" /> | ||
<meta name="viewport" content="width=device-width, initial-scale=1" /> | ||
</head> | ||
<body> | ||
<header> | ||
<h1>Product Pick</h1> | ||
</header> | ||
<main> | ||
<form> | ||
<!-- write your html here--> | ||
<!-- | ||
try writing out the requirements first as comments | ||
this will also help you fill in your PR message later--> | ||
</form> | ||
</main> | ||
<footer> | ||
<!-- change to your name--> | ||
<h2>By HOMEWORK SOLUTION</h2> | ||
</footer> | ||
</body> | ||
<head> | ||
<meta charset="utf-8" /> | ||
<meta http-equiv="X-UA-Compatible" content="IE=edge" /> | ||
<title>My form exercise</title> | ||
<meta name="viewport" content="width=device-width, initial-scale=1" /> | ||
<style> | ||
|
||
label, input[type="radio"], input[type="text"], input[type="email"] { | ||
display: inline-block; | ||
padding: 12px; | ||
margin-bottom: 12px; | ||
} | ||
|
||
input[type="radio"] { | ||
width: 24px; | ||
height: 24px; | ||
} | ||
|
||
.form-group { | ||
margin-bottom: 20px; | ||
} | ||
|
||
fieldset > div { | ||
margin-bottom: 16px; | ||
} | ||
|
||
button { | ||
padding: 14px 28px; | ||
font-size: 16px; | ||
} | ||
</style> | ||
</head> | ||
<body> | ||
<header> | ||
<h1>T-shirt Pick</h1> | ||
</header> | ||
|
||
<main role="main"> | ||
<form action="/my-handling-form-page" method="post" aria-label="T-shirt selection form"> | ||
<div class="form-group"> | ||
<label for="name">Enter your name:</label> | ||
<input type="text" id="name" name="user_name" required aria-required="true" /> | ||
VictoriaScottCodes marked this conversation as resolved.
Show resolved
Hide resolved
|
||
</div> | ||
|
||
<div class="form-group"> | ||
<label for="mail">Enter your email:</label> | ||
<input type="email" id="mail" name="user_email" required aria-required="true" /> | ||
</div> | ||
|
||
<fieldset> | ||
<legend>What colour T-shirt would you like?</legend> | ||
<div> | ||
<input type="radio" id="black" name="colour" value="Black" required /> | ||
<label for="black">Black</label> | ||
</div> | ||
<div> | ||
<input type="radio" id="white" name="colour" value="White" /> | ||
<label for="white">White</label> | ||
</div> | ||
<div> | ||
<input type="radio" id="grey" name="colour" value="Grey" /> | ||
<label for="grey">Grey</label> | ||
</div> | ||
</fieldset> | ||
|
||
<fieldset> | ||
<legend>What size do you want?</legend> | ||
<div> | ||
<input type="radio" id="size-xs" name="size" value="XS" required /> | ||
<label for="size-xs">XS</label> | ||
</div> | ||
<div> | ||
<input type="radio" id="size-s" name="size" value="S" /> | ||
<label for="size-s">S</label> | ||
</div> | ||
<div> | ||
<input type="radio" id="size-m" name="size" value="M" /> | ||
<label for="size-m">M</label> | ||
</div> | ||
<div> | ||
<input type="radio" id="size-l" name="size" value="L" /> | ||
<label for="size-l">L</label> | ||
</div> | ||
<div> | ||
<input type="radio" id="size-xl" name="size" value="XL" /> | ||
<label for="size-xl">XL</label> | ||
</div> | ||
<div> | ||
<input type="radio" id="size-xxl" name="size" value="XXL" /> | ||
<label for="size-xxl">XXL</label> | ||
</div> | ||
</fieldset> | ||
|
||
<div class="form-group"> | ||
<button type="submit" aria-label="Submit your T-shirt selection">Submit</button> | ||
</div> | ||
</form> | ||
</main> | ||
|
||
<footer> | ||
<h2>By Victoria</h2> | ||
</footer> | ||
</body> | ||
</html> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.