Skip to content

ZA | MAY-2025 | NOKWANDA PHEWA | FORM CONTROLS #646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

ZA | MAY-2025 | NOKWANDA PHEWA | FORM CONTROLS #646

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8494045
Form controls:validated
NokwandaPhewa May 29, 2025
cb6108b
improved name validation
NokwandaPhewa Jun 2, 2025
d4d6ca8
Improved for better lighthouse score
NokwandaPhewa Jun 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
84 changes: 72 additions & 12 deletions Form-Controls/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,27 +1,87 @@
<!DOCTYPE html>
<html lang="en">
<head>
<meta charset="utf-8" />
<meta http-equiv="X-UA-Compatible" content="IE=edge" />
<title>My form exercise</title>
<meta name="description" content="" />
<meta name="viewport" content="width=device-width, initial-scale=1" />
<meta charset="utf-8">
<meta http-equiv="X-UA-Compatible" content="IE=edge">
<title>T-Shirt Order Form - Product Pick</title>
<meta name="description" content="Order your custom t-shirt with color and size options">
<meta name="viewport" content="width=device-width, initial-scale=1">
</head>
<body>
<header>
<h1>Product Pick</h1>
</header>

<main>
<!--
UX Design Choices:
1. Size: Radio buttons for clear visual comparison of 6 options
2. Color: Dropdown for compact display of 3 simple choices
3. All fields required for complete submissions
-->
<form>
<!-- write your html here-->
<!--
try writing out the requirements first as comments
this will also help you fill in your PR message later-->
<!-- Customer Info -->
<fieldset>
<legend>Customer Information</legend>
<div>
<label for="name">Full Name:</label><br>
<input type="text" id="name" name="name" required
minlength="2" pattern=".*[^ ].*"
title="Please enter at least 2 non-space characters"
Comment on lines +29 to +30
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The description given in the title attribute does not quite match what the pattern check.
Current pattern can guarantee only "at least one non-space character" in the name.

autocomplete="name">
</div>

<div>
<label for="email">Email Address:</label><br>
<input type="email" id="email" name="email" required
autocomplete="email"><br><br>
</div>
</fieldset>

<!-- Product Selection -->
<fieldset>
<legend>T-Shirt Details</legend>
<div>
<label for="color">Color:</label><br>
<select id="color" name="color" required>
<option value="">--Select Color--</option>
<option value="red">Red</option>
<option value="blue">Blue</option>
<option value="green">Green</option>
</select><br><br>
</div>

<fieldset>
<legend>Size:</legend>
<input type="radio" id="xs" name="size" value="XS" required>
<label for="xs">XS</label><br>

<input type="radio" id="s" name="size" value="S">
<label for="s">S</label><br>

<input type="radio" id="m" name="size" value="M">
<label for="m">M</label><br>

<input type="radio" id="l" name="size" value="L">
<label for="l">L</label><br>

<input type="radio" id="xl" name="size" value="XL">
<label for="xl">XL</label><br>

<input type="radio" id="xxl" name="size" value="XXL">
<label for="xxl">XXL</label>
</fieldset>
</fieldset>

<!-- Submission -->
<div>
<button type="submit" aria-label="Submit t-shirt order form">Place Order</button>
</div>
</form>
</main>

<footer>
<!-- change to your name-->
<h2>By HOMEWORK SOLUTION</h2>
<h2>By Nokwanda Phewa</h2>
</footer>
</body>
</html>
</html>