Skip to content

ZA | ITP-May-2025 | Rashaad Ebrahim | Form Controls #642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

Rashaad-Ebrahim
Copy link

@Rashaad-Ebrahim Rashaad-Ebrahim commented May 28, 2025

Learners, PR Template

Self checklist

  • I have committed my files one by one, on purpose, and for a reason
  • I have titled my PR with REGION | COHORT_NAME | FIRST_NAME LAST_NAME | PROJ_NAME
  • I have tested my changes
  • My changes follow the style guide
  • My changes meet the requirements of this task

Changelist

Form Control order form has been updated in line with requirements.

Radio buttons and select options have been used selectors in the form.

Questions

No questions at this time.

Copy link

netlify bot commented May 28, 2025

Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit b18e815
🔍 Latest deploy log https://app.netlify.com/projects/cyf-onboarding-module/deploys/68379abb947ee9000889ae78
😎 Deploy Preview https://deploy-preview-642--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
2 paths audited
Performance: 96 (🔴 down 4 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 91 (🟢 up 5 from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@Rashaad-Ebrahim Rashaad-Ebrahim linked an issue May 28, 2025 that may be closed by this pull request
3 tasks
@Rashaad-Ebrahim Rashaad-Ebrahim added the Needs Review Participant to add when requesting review label May 28, 2025
@Waldo-Strydom
Copy link

Well done

@Waldo-Strydom Waldo-Strydom added Reviewed Volunteer to add when completing a review Complete Volunteer to add when work is complete and review comments have been addressed and removed Needs Review Participant to add when requesting review labels May 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complete Volunteer to add when work is complete and review comments have been addressed Reviewed Volunteer to add when completing a review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[STEP SUBMISSION] Step 1: Onboarding Module 03 Form Controls
2 participants