CodeYourFuture/Module-Onbording London |May-2025 | Zahedeh Heidari | Wireframe

[Heidari7730]

Learners, PR Template

Self checklist

• I have committed my files one by one, on purpose, and for a reason
• I have titled my PR with REGION | COHORT_NAME | FIRST_NAME LAST_NAME | PROJ_NAME
• I have tested my changes
• My changes follow the style guide
• My changes meet the requirements of this task

Changelist

Briefly explain your PR.

Questions

Ask any questions you have for your reviewer.

[netlify]

✅ Deploy Preview for cyf-onboarding-module ready!

Name	Link
🔨 Latest commit	a243a74
🔍 Latest deploy log	https://app.netlify.com/projects/cyf-onboarding-module/deploys/682b4089bf6e900008fe7ff6
😎 Deploy Preview	https://deploy-preview-559--cyf-onboarding-module.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	2 paths audited Performance: 100 (no change from production) Accessibility: 100 (no change from production) Best Practices: 100 (no change from production) SEO: 86 (no change from production) PWA: - View the detailed breakdown and full score reports

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[Amundeep-Dhaliwal]

Hello Heidari, hope you are well and thank you for submitting this MR.

Was looking over this PR and had a few comments:

• I like how you included a checklist for the tasks that needed to be done for this merge request. It would also be really good if you can complete the change log within the description.
• I liked how you used multiple commits, these descriptions allow a reviewer to follow your thinking when making changes. It would be nice if you could use more descriptive commit messages, for example Added a paragraph tag to the index.html to explain what a README file is.
• It is good that you have described what a wireframe, README files & git branches are. The read more button for README files does not seem to work for me. Would also be nice to capitalise the first letter of each sentence (read more to Read more).
• The images for the wireframe do not appear in the deployed wireframe, are we sure that the image tags are pointing to the right assets?
• The form controls section is not complete yet, we need a way for users of the website to submit a name, email & their T-shirt order.

Overall this is a good first draft of the PR and would encourage you to continue work.