ITP, JAN25, LONDON | YORSALEM MESMER | Onboarding | WEEK 2

[Jerry-yorsalem]

Learners, PR Template

Self checklist

• I have committed my files one by one, on purpose, and for a reason
• I have titled my PR with COHORT_NAME | FIRST_NAME LAST_NAME | REPO_NAME | WEEK
• I have tested my changes
• My changes follow the style guide
• My changes meet the requirements of this task

Changelist

Briefly explain your PR.

Questions

Ask any questions you have for your reviewer.

[netlify]

✅ Deploy Preview for cyf-onboarding-module ready!

Name	Link
🔨 Latest commit	6b18957
🔍 Latest deploy log	https://app.netlify.com/sites/cyf-onboarding-module/deploys/679e40bede045a0008838255
😎 Deploy Preview	https://deploy-preview-233--cyf-onboarding-module.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	2 paths audited Performance: 100 (no change from production) Accessibility: 100 (no change from production) Best Practices: 100 (no change from production) SEO: 86 (no change from production) PWA: - View the detailed breakdown and full score reports

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[cjyuan]

Please create separate branches for separate exercises, and submit separate PRs.

[A-O-Emmanuel]

I think this is okay, however, your commit messages need to better communicate the changes made. Please look at this article How to write Better Git Commit Messages

Also, i think improving your indentation and spacing will make the presentation of your html better. consider going through this article How to indent HTML code and why it's important

Also, from the wireframe provided to you, the page title, short description, the three article blocks and footer, ought to be centered. The two article blocks below the first article block ought to have the same height. To add to that, the title, text and read more link of the three article blocks ought to be left aligned.

[Jerry-yorsalem]

Thanks for the feedback, I will!

…

On Wed, 12 Feb 2025 at 08:12, Obinna Obi-Akwari ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ On Wireframe/index.html <#233 (comment)> : I think this is okay, however, your commit messages need to better communicate the changes made. Please look at this article How to write Better Git Commit Messages <https://www.freecodecamp.org/news/how-to-write-better-git-commit-messages/> — Reply to this email directly, view it on GitHub <#233 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/BNB4D2YG3U2EGY42S3ORWVD2PL65TAVCNFSM6AAAAABWJLA6LWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDMMJRGEZDEMJVGA> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[A-O-Emmanuel]

This is good, consider merging the two main blocks into one. as having them separately can cause redundant or conflicting styles.