Maheag|OnboardingForm|Week2 #164
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
<!-- You must title your PR like this: COHORT_NAME | FIRST_NAME LAST_NAME | REPO_NAME | WEEK For example, NW4 | Carol Owen | HTML-CSS-Module | Week1 Complete the task list below this message. If your PR is rejected, check the task list. --> ## Learners, PR Template Self checklist - [√ ] I have committed my files one by one, on purpose, and for a reason - [√ ] I have titled my PR with COHORT_NAME | FIRST_NAME LAST_NAME | REPO_NAME | WEEK - [ √] I have tested my changes - [ √] My changes follow the [style guide](https://curriculum.codeyourfuture.io/guides/reviewing/style-guide/) - [√ ] My changes meet the [requirements](./README.md) of this task ## Changelist Briefly explain your PR. ## Questions Ask any questions you have for your reviewer.
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Please use labels and add your cohort name. |
Waldo-Strydom
added
👀 Review Git
|
Good morning Waldo,
Thank you for your review. I see. I will delete CSS and will use html to organise the page better.
Best wishes
Maheag
________________________________
From: Waldo Strydom ***@***.***>
Sent: 26 January 2025 15:31
To: CodeYourFuture/Module-Onboarding ***@***.***>
Cc: Maheag ***@***.***>; Author ***@***.***>
Subject: Re: [CodeYourFuture/Module-Onboarding] Maheag|OnboardingForm|Week2 (PR #164)
@Waldo-Strydom commented on this pull request.
________________________________
In Form-Controls/index.html<#164 (comment)>:
+ <label for="qtt">Quantity:</label>
+ <input type="number" id="qtt" name="quantity" required><br>
+
+ <label for="size">T-Shirt Size:</label>
+ <select id="size" name="size" required>
+ <option value="" disabled selected>Select a size</option>
+ <option value="XS">XS</option>
+ <option value="S">S</option>
+ <option value="M">M</option>
+ <option value="L">L</option>
+ <option value="XL">XL</option>
+ <option value="XXL">XXL</option>
+ <option value="XXXL">XXXL</option>
+ </select>
+
+ <div class="delivery-container">
Remove this. It is not in the brief.
________________________________
In Form-Controls/index.html<#164 (comment)>:
+ <label for="city">City:</label>
+ <input type="text" id="city" name="city" required>
+
+ <label for="state">County:</label>
+ <input type="text" id="state" name="state" required>
+
+ <label for="zip">Post Code:</label>
+ <input type="text" id="zip" name="zip" required>
+ </div>
+
+ <label for="deliveryDate">Select a delivery date:</label>
+ <input type="date" id="deliveryDate" name="deliveryDate" required>
+ <button type="submit">Submit</button>
+ </form>
+
+ <script>
No JS allowed. Remove it
________________________________
In Form-Controls/style.css<#164 (comment)>:
@@ -0,0 +1,54 @@
+body {
No CSS Allowed. Remove it.
—
Reply to this email directly, view it on GitHub<#164 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/BFJOX5QM7FYZVFQUSJ67WTT2MT5V3AVCNFSM6AAAAABVKHS7KWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDKNZUGMYTEMBTGI>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
xxxl size deleted as not requested on brief
JS deleted as requested
update restricted date using html only. As requested
deleted line 9 Css file
applying break lines
| <h2>T-Shirt Order Form</h2> | ||
| <form id="tshirtOrderForm"> | ||
| <label for="name">Confirm your Name:</label> | ||
| <input type="text" id="name" name="name" required pattern="[A-Za-z\s]+" title="Please enter a valid name (letters and spaces only)."><br> |
There was a problem hiding this comment.
Please require a min of 2 characters.
|
|
||
|
|
||
|
|
||
| <label for="date">Select a date:</label> |
There was a problem hiding this comment.
Date not in the brief. Please remove it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Briefly explain your PR.
Questions
Ask any questions you have for your reviewer.