-
-
Notifications
You must be signed in to change notification settings - Fork 268
ITP-JAN-25 | EYUEL_ABRAHAM| | Module-Onboarding Feature/wireframe | Week 1 #126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Goog work, here is a challenge for you, it would be really nice to make this page also mobile friendly, you can display last two articles as rows in mobile screen
|
||
<div class="bottom-side"> | ||
<article> | ||
<img src="placeholder.svg" alt="" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you tell me why we have to use alt tags in img elements, please do not forget to fill alt tags in images
<p> | ||
Code your future 2024. | ||
</p> | ||
</div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Footer position is fixed but you should also show footer's background, if not user can't clearly see where footer starts and also due to z-index problem, it creates barrier for user to click on read more button if you scroll to top, please refers to these issue.
Learners, PR Template
Self checklist
Changelist
Briefly explain your PR.
Questions
Ask any questions you have for your reviewer.