Skip to content

Sheffield | 25-ITP-May | Declan Williams | Data-Groups-Sprint 1 #695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 35 commits into
base: main
Choose a base branch
from
Open

Sheffield | 25-ITP-May | Declan Williams | Data-Groups-Sprint 1 #695

wants to merge 35 commits into from

Conversation

CatchingKiyoko
Copy link

Learners, PR Template

Self checklist

  • I have committed my files one by one, on purpose, and for a reason
  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • I have tested my changes
  • My changes follow the style guide
  • My changes meet the requirements of this task

Changelist

implemented functions, jest tests, refactored and debugged and fixed code in each of the required coursework folders
Briefly explain your PR.

Questions

Ask any questions you have for your reviewer.

@CatchingKiyoko
Refactor calculateMedian function to ensure input is an array before …
5decc55 
…processing
@CatchingKiyoko
Fix calculateMedian function to filter out non-number values from the…
5b12f55 
… input array
@CatchingKiyoko
Fix calculateMedian function to correctly compute the median value fr…
1c395d6 
…om filtered numbers
@CatchingKiyoko
Add check to return null if no valid numbers are present in calculate…
11a010f 
…Median function
@CatchingKiyoko
Fix calculateMedian function to ensure sorting occurs before finding …
589fef7 
…the median
@CatchingKiyoko
Refactor includes function to use for...of loop for improved readability
fc0d9bc
@CatchingKiyoko
implement: initialize newArray ready to store unique values for dedup…
4199529 
…lication
@CatchingKiyoko
feat: implement for...of loop to iterate through input array
df0b19c
@CatchingKiyoko
added check to prevent duplicate values using .includes()
a93c361
@CatchingKiyoko
implemented: push non-duplicate items to unique array and return the …
88ef053 
…newArray output
@CatchingKiyoko
fix: add missing array parameter to dedupe function
00abcc4
@CatchingKiyoko
refactored: removed console.log
1e3002d
@CatchingKiyoko
reimplmented the module.exports for tests
d5cc4cf
@CatchingKiyoko
implemented tests for giving the function an array with no duplicates…
5fde149 
… and empty arrays
@CatchingKiyoko
add unit tests for dedupe function to ensure it removes duplicates wh…
b07f167 
…ile preserving first occurrences
@CatchingKiyoko
feat: implement findMax function to filter numbers from an array
128a345
@CatchingKiyoko
implemented findMax function to return the maximum number from an array
05d5b01
@CatchingKiyoko
implemented findMax function to return -Infinity when array is empty
f630baa
@CatchingKiyoko
fix: move empty array check to the correct position in findMax function
2235414
@CatchingKiyoko
updated test for findMax function when given an empty array
4bcc171
@CatchingKiyoko
added test a array has one number in and returns that number
f84d2f2
@CatchingKiyoko
added jest Test given an array with both positive and negative number…
e78614b 
…s, returns the largest
@CatchingKiyoko
added jest Test: given an array with just negative numbers, returns t…
ff06a57 
…he closest one to zero
@CatchingKiyoko
added jest Test: given an array with decimal numbers, returns the lar…
f0d4e09 
…gest decimal number
@CatchingKiyoko
added jest test: given an array with non-number values, returns the m…
426d205 
…ax and ignores non-numeric values
@CatchingKiyoko
added jest test: given an array with only non-number values, returns …
4221f01 
…-Infinity
@CatchingKiyoko
Add check to return 0 if input array is empty in sum function
b656247
@CatchingKiyoko
added jest test for if given an array is empty
5e62085
@CatchingKiyoko
added for...of loop for to check elements in the arrays are numbers a…
de951df 
…nd adds numbers to total sum
@CatchingKiyoko
added jest test for if an array has just one number
d87cea0
@CatchingKiyoko CatchingKiyoko added 📅 Sprint 1 Assigned during Sprint 1 of this module Needs Review Participant to add when requesting review labels Jul 24, 2025
@CatchingKiyoko CatchingKiyoko linked an issue Jul 24, 2025 that may be closed by this pull request
[TECH ED] Complete sprint 1 exercises CatchingKiyoko/My-Coursework-Planner#27
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Needs Review Participant to add when requesting review 📅 Sprint 1 Assigned during Sprint 1 of this module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[TECH ED] Complete sprint 1 exercises
1 participant
@CatchingKiyoko