Sheffield | May-2025 | Waleed-Yahya Salih-Taha | DataGroup-sprint 2 #672
Conversation
removed extra space.
…ty object with test one
added the test code in the invert.js file and run the test all passed.
Run the test and passed all of it.
Bluejay600
added
📅 Sprint 2
… returns an object. Added all the advanced challenges and tested them.
…p in this function?
Bluejay600
changed the title
| if (typeof obj !== 'object' || obj === null || Array.isArray(obj)) { | ||
| return false; | ||
| } | ||
| return Object.prototype.hasOwnProperty.call(obj, key); |
There was a problem hiding this comment.
Could also use Object.hasOwn(obj, key).
|
|
||
| // Given invalid parameters like an array | ||
| // When passed to contains | ||
| // Then it should return false or throw an error | ||
| test("contains on array returns false", () => { | ||
| expect(contains([1, 2, 3], 'a')).toBe(false); |
There was a problem hiding this comment.
contains([1, 2, 3], "a") could also return false because "a" is not a property (or key) of [1, 2, 3].
However, "0", "1", "2" are keys of [1, 2, 3], so it is better to specify the test as
expect(contains([1, 2, 3], "1")).toBe(false); (to ensure you are checking what you describe)
There was a problem hiding this comment.
The file Sprint-2/implement/querystring.js (which contains the implementation of the function) was not updated.
| function tally(arr) { | ||
| if (!Array.isArray(arr)) { | ||
| throw new Error("Input must be an array"); | ||
| } | ||
| return arr.reduce((acc, item) => { | ||
| acc[item] = (acc[item] || 0) + 1; | ||
| return acc; | ||
| }, {}); | ||
| } |
There was a problem hiding this comment.
Does the following function call returns the value you expect?
tally(["toString", "toString"]);
| const words = cleanedStr.split(/\s+/); | ||
|
|
||
| // Create an object to store word counts | ||
| const wordCount = {}; | ||
|
|
||
| for (let word of words) { | ||
| if (wordCount[word]) { | ||
| wordCount[word]++; | ||
| } else { | ||
| wordCount[word] = 1; | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
Can you check if your function returns what you expect in the following function calls?
countWords("Hello,World! Hello World!");
countWords("constructor constructor");
countWords(" Hello World ");
|
|
||
| // Optional: Sort the results by frequency (most common first) | ||
| const sortedWordCount = Object.fromEntries( | ||
| Object.entries(wordCount).sort((a, b) => b[1] - a[1]) |
There was a problem hiding this comment.
In (a, b) => b[1] - a[1], it is not clear what the 2nd element of the parameters represents.
Can you think of a way to make the code more readable? (Hint: Use array destructuring on the parameters).
| total += coin * quantity; | ||
| for (const [coin, quantity] of Object.entries(till)) { | ||
| // Remove the "p" and convert to number | ||
| const coinValue = parseInt(coin.replace("p", ""), 10); |
There was a problem hiding this comment.
Can you find out why the following statement work equally well (compare to the statement at line 12)?
const coinValue = parseInt(coin);
There was a problem hiding this comment.
Sprint-3/quote-generator/index.html does not belong to Sprint-2. Can you revert the change to this file?
cjyuan
added
Reviewed
Learners, PR Template
Self checklist
Changelist
this PR gives a short set of requirements about a function. and You will need to implement, interpret and and sometimes fix a function based off this set of requirements
Questions
Ask any questions you have for your reviewer.