Skip to content

London | May-2025 | Sisay Mehari | Quote Generator App #593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Sisu860
Copy link

@Sisu860 Sisu860 commented Jul 12, 2025

Self checklist

  • I have committed my files one by one, on purpose, and for a reason
  • I have titled my PR with REGION | COHORT_NAME | FIRST_NAME LAST_NAME | PROJ_NAME
  • I have tested my changes
  • My changes follow the style guide
  • My changes meet the requirements of this task

🚀 Quote Generator App
This pull request adds a quote generator that:

Displays a random quote with its author

Lets the user generate new quotes by clicking a button

Is styled with basic HTML & CSS

✅ What’s included
HTML structure for quote and author

JavaScript functionality using querySelector, addEventListener, and a helper function pickFromArray

Styling to make the app readable and clean

Tests that check:

The initial quote is rendered correctly

Clicking the button shows a new quote

Test file: quotes.test.js

Helper: pickFromArray(choices) to pick a quote randomly

🧪 Testing
All tests pass (npm test ✅)

Covered:

Initial quote display

Changing to new quotes

Used JSDOM, @testing-library/user-event, and controlled Math.random() for predictable test results

Questions:
None at the moment.

@Sisu860 Sisu860 added the Needs Review Participant to add when requesting review label Jul 12, 2025
@A-O-Emmanuel A-O-Emmanuel added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Participant to add when requesting review labels Jul 13, 2025
Copy link

@A-O-Emmanuel A-O-Emmanuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good to me, good work, when I click on the new quote button, it does change the quote and the author of the quote, good work

@A-O-Emmanuel A-O-Emmanuel added Reviewed Volunteer to add when completing a review and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Jul 13, 2025
@Sisu860
Copy link
Author

Sisu860 commented Jul 13, 2025

Thank you so much can you please put the complete label?

@A-O-Emmanuel A-O-Emmanuel added Complete Volunteer to add when work is complete and review comments have been addressed and removed Reviewed Volunteer to add when completing a review labels Jul 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complete Volunteer to add when work is complete and review comments have been addressed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants