London | May-2025 | KhilolaRustamova |Mdg/sprint 2

[HilolaRustam]

Learners, PR Template

Self checklist

• I have committed my files one by one, on purpose, and for a reason
• I have titled my PR with REGION | COHORT_NAME | FIRST_NAME LAST_NAME | PROJ_NAME
• I have tested my changes
• My changes follow the style guide
• My changes meet the requirements of this task

Changelist

Briefly explain your PR.

Questions

Ask any questions you have for your reviewer.

[AdnanGondal]

Great explanations and solutions for the debug section - well done.

[AdnanGondal]

Perhaps it would be better to add different edge cases to these tests such as what happens when:

• Empty input
• When there are duplicate keys
• When a pair has extra values, such as createLookup([["UK", "GBP", "Extra"]])).

[HilolaRustam]

i added some more test cases.

[AdnanGondal]

A great set of test cases. Just had one question.
What do you expect to happen when you run parseQueryString("a=1&&b=2").
Can you add a test case for it?

[HilolaRustam]

test is going to look like this.
test("parses multiple key-value pairs", () => {
expect(parseQueryString("a=1&&b=2")).toEqual({ a: "1", "", b: "2" });
});

[AdnanGondal]

A great submission - but I have added some comments regarding additional test cases. Once done, let me know and I will mark as Complete.