Glasgow | ITP MAY | MIRABELLE MORAH | Module Data Groups | Sprint-2 #587
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LonMcGregor
added
Review in progress
LonMcGregor
reviewed
Jul 14, 2025
| expect(contains(undefined, "a")).toBe(false); | ||
| expect(contains(42, "a")).toBe(false); | ||
| }); | ||
| }); |
| expect(parseQueryString("name=John%20Doe&city=New%20York")).toEqual({ | ||
| name: "John Doe", | ||
| city: "New York", | ||
| }); |
| const counts = {}; | ||
| for (const item of list) { | ||
| counts[item] = (counts[item] || 0) + 1; | ||
| } |
There was a problem hiding this comment.
This is a clever and quick way of initialising the object
|
|
||
| // d) Explain why the current return value is different from the target output | ||
|
|
||
| // ... The current implementation incorrectly assigns the value to the key property of invertedObj instead of using the value as a key in invertedObj. fixed by using invertedObj[value] = key; |
There was a problem hiding this comment.
I'm grateful and thank you
LonMcGregor
added
Complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Created tests
Questions
liN