London | ITP-May-2025 | Hibo Sharif | Module-Data-Groups | Alarm clock #584
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…background, flashing effect and pause button.
hibosharif202504
added
the
Needs Review
MorganDavid
added
Complete
|
Looks good to me! well done! |
MorganDavid
reviewed
Jul 12, 2025
Comment on lines
58
to
+62
| function pauseAlarm() { | ||
| audio.pause(); | ||
| document.body.classList.remove("flash"); | ||
| } | ||
|
|
There was a problem hiding this comment.
Would this function be better called stopAlarm?
There was a problem hiding this comment.
Ideally, we should also clear all the timer variables when we stop the alarm, so they're ready for next time, with clearInterval and timeRemaining = 0
There was a problem hiding this comment.
Hi @MorganDavid ,
Thank you for the review. I will make the changes to the file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
I have implemented changes to the alarmclock.js file to update the setup of the alarm. I have also made changes to the CSS style and the index.html files to add new features to the alarm clock app.
Questions
Ask any questions you have for your reviewer.