London | ITP-May-2025 | Sisay Mehari | Module-Data-Groups | Sprint 2 #583

Sisu860 · 2025-07-11T14:57:58Z

Learners, PR Template

Self checklist

I have committed my files one by one, on purpose, and for a reason
I have titled my PR with REGION | COHORT_NAME | FIRST_NAME LAST_NAME | PROJ_NAME
I have tested my changes
My changes follow the style guide
My changes meet the requirements of this task

Changelist
✅ Completed Work Summary
This batch of commits includes several key improvements across object handling, function refactoring, string parsing, and utility implementations — all with input validation and test coverage.

🏠 Object Property Access & Iteration
Correctly access the houseNumber property from nested address objects.

Implemented reliable iteration over object property values for better data processing.

Fixed ingredient list logging to output correctly formatted arrays.

🔍 Utility Functions & Parsing
Added a contains function with thorough input validation and comprehensive tests.

Created createLookup function, converting arrays into lookup objects for faster access.

Improved query string parser to correctly handle multiple test cases.

📊 Counting & Frequency Functions
Implemented tally function that counts occurrences with proper parameter handling.

Refined the invert function with added tests and bug fixes for base cases.

Split calculateMode into smaller, focused functions to improve readability and maintainability.

💰 Coin Calculation Fixes
Fixed coin calculation logic by parsing coin keys safely and ignoring invalid entries.

Added tests to ensure robustness against unknown or malformed keys in input objects.

🕒 Recent Commits Highlights
Added a function to count words and return a frequency object with key-value pairs.

Completed breaking down calculateMode into smaller modular functions.

Fixed totalTill function to parse and sum coin values correctly, handling edge cases.

🧪 Testing
Full test coverage added for new and updated functions.

Tests cover edge cases, invalid inputs, and common usage scenarios to ensure reliability.

Questions
None at the moment.

…ting

…ic and edge cases

…d value.

… and add test

Sprint-2/implement/lookup.js

hkavalikas · 2025-07-19T07:31:17Z

Sprint-2/implement/lookup.js

@@ -1,5 +1,7 @@
-function createLookup() {
+function createLookup(key, value) {
+  return Object.fromEntries(key, value);
  // implementation here


Minor, but can we move the function implementation under this line for consistency?

I have made the changes.

Comments like // implement here here OR // TODO: Add X here are pretty handy to follow and search for.
While minor, it's a good idea to follow the instructions where possible and add the solution under those comments e.g. in your case, return Object.fromEntries([[key, value]]);

Thank you for the helpful comments. I implemented it in my case.

hkavalikas · 2025-07-19T07:35:46Z

Sprint-2/implement/lookup.test.js

@@ -1,6 +1,10 @@
 const createLookup = require("./lookup.js");

-test.todo("creates a country currency code lookup for multiple codes");
+test("creates a country currency code lookup for multiple codes", () => {


Completely optional, but can you think of any other test case worth adding here beyond the happy path one?

I considered multiple test cases.

Awesome job ✅

hkavalikas · 2025-07-19T07:49:50Z

Sprint-2/implement/querystring.test.js

+    "category": ["books", "movies", "music"]
+  })
+});
+test("parses querystring with empty values", () => {


What is the difference between the test case here and line 30?

completely the same, I have made the test changes again.

hkavalikas · 2025-07-19T07:53:43Z

Sprint-2/implement/querystring.test.js

@@ -10,3 +10,28 @@ test("parses querystring values containing =", () => {
    "equation": "x=y+1",
  });
 });
+


Can you think of any other test case/scenario we might come across with our application?

Hint: Think of the argument types we can pass to the function, would any type cause unexpected side effects to our flow?

I have fully considered non-string inputs. I added a test case where the function receives a number or null. I updated the function to handle unexpected types more safely.

hkavalikas · 2025-07-19T10:29:00Z

Sprint-2/interpret/invert.js

  }

  return invertedObj;
 }
+console.log(invert({ a: 1, b: 2 }));


Console logs (among other methods) are an awesome way of debugging your code, but most of the time (not a hard rule, but applicable in most cases), it might not be something you want to commit.

Imagine troubleshooting user data with sensitive information and passwords; logging them could end up being a security issue.

I hadn’t thought about the risk of accidentally logging sensitive info. I’ll make sure to remove any debug console.logs before committing code going forward. In this case, I have removed all the console.logs. Thanks for the reminder.

hkavalikas · 2025-07-19T10:36:29Z

Sprint-2/interpret/invert.test.js

This covers most of the basic test cases and looks awesome 👏

If I add an additional interesting question, how would your implementation handle duplicate values like { a : 1, b : 2, c : 1 } ?

I suggest trying to come up with an answer before running your code -> expected return type of your current implementation, how would you handle this scenario and finally make any changes/add tests if needed.

I updated the function to check if a value already exists; if it does, it converts it into an array (or adds to it). I also added a new test case to cover that scenario.

hkavalikas · 2025-07-19T10:40:52Z

Sprint-2/stretch/count-words.js

@@ -26,3 +26,17 @@

 3. Order the results to find out which word is the most common in the input
 */
+function countWords(str) {


Function is looking great, but is it passing all requirements? Specifically,

- takes a string as an argument - returns an object where - the keys are the words from the string and - the values are the number of times the word appears in the string

The function was returning a sorted array instead of an object. I’ve updated it to return an object where each word is a key and the value is the count. It now meets all the listed requirements.

hkavalikas · 2025-07-19T10:41:43Z

Sprint-2/stretch/count-words.js

+}
+
+
+console.log(countWords("you and me and you"));


Not awfully important but a good habit, please read https://github.com/CodeYourFuture/Module-Data-Groups/pull/583/files#r2217271192

Sharing for interest purposes only, but in production projects, you usually have tools that will warn/error when certain practices are followed. A good example of that is https://eslint.org/ , an amazing little tool that can check your project for different rules, one of which is this.

That makes a lot of sense.

hkavalikas · 2025-07-19T10:44:11Z

Sprint-2/stretch/till.js

@@ -21,11 +25,21 @@ const till = {
  "20p": 10,
 };
 const totalAmount = totalTill(till);
+console.log(totalAmount);


Not awfully important but a good habit, please read https://github.com/CodeYourFuture/Module-Data-Groups/pull/583/files#r2217271192

modified: Sprint-3/slideshow/slideshow.js modified: Sprint-3/slideshow/style.css

….fromEntries

… array return

Sisu860 · 2025-07-20T12:14:25Z

All required changes have been made, I've updated the code and added any missing test cases. Can you please check and put the complete label?

hkavalikas · 2025-07-22T13:16:20Z

It's quite common to have a little thread/discussion under a PR, especially if there are questions or disagreements with an approach. You can click where it says Reply... on any of my comments and reply there, especially for the comments that ask for a walkthrough/explanation. That way you don't have to commit a comment with your answer (which you might typically not want to do on a production codebase, but that's less important here though)

hkavalikas · 2025-07-22T13:33:59Z

Four comments remaining:

…ng Object.fromEntries

Sisu860 · 2025-07-22T20:18:49Z

It's quite common to have a little thread/discussion under a PR, especially if there are questions or disagreements with an approach. You can click where it says Reply... on any of my comments and reply there, especially for the comments that ask for a walkthrough/explanation. That way you don't have to commit a comment with your answer (which you might typically not want to do on a production codebase, but that's less important here though)

Thanks for the reminder. I’ll make sure to reply directly under your comments next time, especially for those that need a walkthrough or clarification. I appreciate the note about not needing to commit those kinds of responses in a real codebase.

hkavalikas · 2025-07-23T09:11:20Z

It's quite common to have a little thread/discussion under a PR, especially if there are questions or disagreements with an approach. You can click where it says Reply... on any of my comments and reply there, especially for the comments that ask for a walkthrough/explanation. That way you don't have to commit a comment with your answer (which you might typically not want to do on a production codebase, but that's less important here though)

Thanks for the reminder. I’ll make sure to reply directly under your comments next time, especially for those that need a walkthrough or clarification. I appreciate the note about not needing to commit those kinds of responses in a real codebase.

Awesome, reminder there are a few more things to address:
#583 (comment)

Sisu860 · 2025-07-23T22:07:37Z

I have addressed all the requirements and the changes. I hope this meets the requirement.

hkavalikas · 2025-07-24T05:46:02Z

PR looks great, awesome job ⭐

Sisu860 added 11 commits July 7, 2025 21:47

correctly access houseNumber property from address object

deb15e1

to iterate over object property values correctly

6bd5df8

log ingredients list correctly

2f62e92

Add contains function with input validation and related tests

e8aa86b

Add createLookup function to convert array of into an object

08f3114

Fix query string parser to handle multiple test

e1f5bae

implement tally function with proper parameter handling and item coun…

82ab40b

…ting

Add tests for invert function , correct the function and covering bas…

01dec66

…ic and edge cases

writing a function that counts word and returns an object with key an…

1c19c06

…d value.

calculateMode into smaller functions

fd1491f

Fix calculation by parsing coin keys safely and ignoring invalid ones…

1e8c2ca

… and add test

Sisu860 added 📅 Sprint 2 Assigned during Sprint 2 of this module Needs Review Participant to add when requesting review labels Jul 11, 2025

hkavalikas added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Participant to add when requesting review labels Jul 19, 2025

hkavalikas self-requested a review July 19, 2025 06:54

hkavalikas suggested changes Jul 19, 2025

View reviewed changes

hkavalikas added Reviewed Volunteer to add when completing a review and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Jul 19, 2025

Sisu860 added 7 commits July 19, 2025 23:18

modified: Sprint-3/slideshow/index.html

2f38ca6

modified: Sprint-3/slideshow/slideshow.js modified: Sprint-3/slideshow/style.css

Update createLookup to return object from key-value pair using Object…

157276c

….fromEntries

adding more test cases

42a41e2

Allow parseQueryString to accept full URL and extract query portion

6ed879b

multiple test scenario covered

834b021

Adding additional implementation and tests.

ad5cdf8

return an object of word frequencies as required, removing the sorted…

ae84c9a

… array return

Sisu860 added the Needs Review Participant to add when requesting review label Jul 20, 2025

Sisu860 requested a review from hkavalikas July 20, 2025 12:15

hkavalikas removed the Needs Review Participant to add when requesting review label Jul 22, 2025

hkavalikas added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Reviewed Volunteer to add when completing a review labels Jul 22, 2025

hkavalikas added Reviewed Volunteer to add when completing a review and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Jul 22, 2025

Update createLookup to transform an array of pairs into an object usi…

bcc85f1

…ng Object.fromEntries

Sisu860 added the Needs Review Participant to add when requesting review label Jul 22, 2025

Sisu860 added Needs Review Participant to add when requesting review and removed Needs Review Participant to add when requesting review labels Jul 23, 2025

hkavalikas added Complete Volunteer to add when work is complete and review comments have been addressed and removed Needs Review Participant to add when requesting review Reviewed Volunteer to add when completing a review labels Jul 24, 2025

Sisu860 mentioned this pull request Jul 24, 2025

May 2025 | Data groups | Sisay Mehari Sisu860/My-Coursework-Planner#104

Open

Uh oh!

London | ITP-May-2025 | Sisay Mehari | Module-Data-Groups | Sprint 2 #583

Are you sure you want to change the base?

London | ITP-May-2025 | Sisay Mehari | Module-Data-Groups | Sprint 2 #583

Uh oh!

Conversation

Sisu860 commented Jul 11, 2025

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Sisu860 commented Jul 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hkavalikas commented Jul 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hkavalikas commented Jul 22, 2025

Uh oh!

Sisu860 commented Jul 22, 2025

Uh oh!

hkavalikas commented Jul 23, 2025

Uh oh!

Sisu860 commented Jul 23, 2025

Uh oh!

hkavalikas commented Jul 24, 2025

Uh oh!

Uh oh!

Sisu860 commented Jul 20, 2025 •

edited

Loading

hkavalikas commented Jul 22, 2025 •

edited

Loading