LONDON | MAY_2025 | EMILIANO_URUENA | DATA_GROUPS | SPRINT2 #580

Emilianouz · 2025-07-11T10:17:42Z

Self checklist

I have committed my files one by one, on purpose, and for a reason
I have titled my PR with REGION | COHORT_NAME | FIRST_NAME LAST_NAME | PROJ_NAME
I have tested my changes
My changes follow the style guide
My changes meet the requirements of this task

Changelist

Sprint 2 - Module DATA GROUPS
COMMITS:

Debugs: address.js, author.js, recipe.js, were debuged. | Sprint-2 MODULE-DATA-GROUPS
Implemented: contains, lookup, querystring, and tally were implemented with their test, according to instructions. | Sprint-2 MODULE-DATA-GROUPS
Interpret: Questions answered in invert.js, created the test and solve it. | Sprint-2 MODULE-DATA-GROUPS

… MODULE-DATA-GROUPS

…nted with their test, according to instructions. | Sprint-2 MODULE-DATA-GROUPS

…olve it. | Sprint-2 MODULE-DATA-GROUPS

MorganDavid

Nice job! A few little things to have a look at. Let me know if anything isn't clear.

MorganDavid · 2025-07-12T10:22:26Z

Sprint-2/debug/address.js

@@ -12,4 +12,4 @@ const address = {
  postcode: "XYZ 123",
 };

-console.log(`My house number is ${address[0]}`);
+console.log(`My house number is ${address["houseNumber"]}`);


This is correct, another correct option is address.houseNumber

MorganDavid · 2025-07-12T10:24:21Z

Sprint-2/debug/author.js

+for (const value of Object.keys(author)) {
  console.log(value);
-}
+} 


An object is made up of keys and values:

{ <key>: <value> }

The keys in this example are firstName, lastName, etc.
The values are "Zadie", "Smith", etc.

The comment at the top asks you to log the values. Is that what your code does?

MorganDavid · 2025-07-12T10:34:06Z

Sprint-2/implement/lookup.js

  // implementation here
+  let objectLookup = {}
+  for (i = 0 ; i<  countryCurrencyPairs.length ; i++){
+    //const [country, currency] = countryCurrencyPairs[i]
+     //objectLookup[country] = currency;
+    objectLookup[countryCurrencyPairs[i][0]] = countryCurrencyPairs[i][1];
+  }
+  return objectLookup


This is good! Alternatively, there's actually a built in javascript function to do this:

Suggested change

// implementation here

let objectLookup = {}

for (i = 0 ; i< countryCurrencyPairs.length ; i++){

//const [country, currency] = countryCurrencyPairs[i]

//objectLookup[country] = currency;

objectLookup[countryCurrencyPairs[i][0]] = countryCurrencyPairs[i][1];

}

return objectLookup

return Object.fromEntries(countryCurrencyPairs);

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/fromEntries

MorganDavid · 2025-07-12T10:40:18Z

Sprint-2/implement/querystring.js

-    const [key, value] = pair.split("=");
-    queryParams[key] = value;
+    //const [key, value] = pair.split("=", 2);
+     const [key, value] = [pair.slice(0,pair.indexOf('=')),pair.slice(pair.indexOf('=')+1)];


I find this line a bit hard to understand. Maybe we could split it up into multiple variables?

Suggested change

const [key, value] = [pair.slice(0,pair.indexOf('=')),pair.slice(pair.indexOf('=')+1)];

const equalsIndex = pair.indexOf('=');

const [key, value] = [pair.slice(0,equalsIndex),pair.slice(pair.indexOf('=')+1)];

Breakingn it up into multiple lines with clear names makes it easier to follow. You could also break out all the other parts of this.

MorganDavid · 2025-07-12T10:43:17Z

Sprint-2/implement/querystring.test.js

+  expect(parseQueryString("sort=newest&color=blue")).toEqual({
+    sort: "newest",
+    color: "blue",
+  });
+});


We could also test for these additional cases:

What happens if the string contains multiple equals signs? e.g. a=b=c=c&b=a,

What happens if the query string is null, e.g. a in this example: a=&b=hello

MorganDavid · 2025-07-12T10:46:42Z

Sprint-2/implement/tally.test.js

+describe('tally',() =>{
+    [
+        {input:['a'], expected:{ a: 1 }},
+        {input:['a', 'a', 'a'], expected:{ a: 3 }},
+        {input:['a', 'a', 'b', 'c'], expected:{ a : 2, b: 1, c: 1 }},
+        {input:[], expected:{}},
+        {input: 'String', expected: new Error("Input must be array")},
+    ].forEach(({input,expected})=>
+    it(`return an object containing the count for each unique item for [${input}]`,()=>
+    expect(tally(input)).toEqual(expected))
+);


This testing pattern is great for adding new test cases easily, but the downside is that if a test fails, it can be hard to work out why it has failed, if each test has a clear message, it's more obvious what has gone wrong.

I think either approach is valid though!

MorganDavid · 2025-07-12T10:50:08Z

Sprint-2/interpret/invert.test.js

+    [
+        {input:{x : 10, y : 20}, expected:{"10": "x", "20": "y"}},
+        {input:{ a : 1 }, expected:{ 1 : "a" }},
+        {input:{a : 1, b: 2}, expected:{ 1 : "a" , 2 : "b" }},


what happens if there are multiple identical values? Objects cannot have multiple identical keys.

I'm not sure what should happen in this case.

You could test for it with

Suggested change

{input:{a : 1, b: 2}, expected:{ 1 : "a" , 2 : "b" }},

{input:{a : 1, b: 1}, expected:/* What happens here? */ },

modified: Sprint-2/debug/author.js modified: Sprint-2/implement/querystring.js modified: Sprint-2/implement/querystring.test.js modified: Sprint-2/interpret/invert.test.js

Emilianouz added 3 commits July 11, 2025 11:12

1. Debugs: address.js, author.js, recipe.js, were debuged. | Sprint-2…

3be7b63

… MODULE-DATA-GROUPS

2. Implemented: contains, lookup, querystring, and tally were impleme…

d9a8561

…nted with their test, according to instructions. | Sprint-2 MODULE-DATA-GROUPS

3. Interpret: Questions answered in invert.js, created the test and s…

0c34049

…olve it. | Sprint-2 MODULE-DATA-GROUPS

Emilianouz added 📅 Sprint 2 Assigned during Sprint 2 of this module Needs Review Participant to add when requesting review labels Jul 11, 2025

This was referenced Jul 11, 2025

[TECH ED] Complete sprint 2 exercises Emilianouz/My-Coursework-Planner#88

Closed

[TECH ED] 📝 Code review Emilianouz/My-Coursework-Planner#87

Closed

MorganDavid suggested changes Jul 12, 2025

View reviewed changes

MorganDavid added Reviewed Volunteer to add when completing a review and removed Needs Review Participant to add when requesting review labels Jul 12, 2025

Changes after review:

95fef2a

modified: Sprint-2/debug/author.js modified: Sprint-2/implement/querystring.js modified: Sprint-2/implement/querystring.test.js modified: Sprint-2/interpret/invert.test.js

Emilianouz added Needs Review Participant to add when requesting review and removed Reviewed Volunteer to add when completing a review labels Jul 15, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

LONDON | MAY_2025 | EMILIANO_URUENA | DATA_GROUPS | SPRINT2 #580

LONDON | MAY_2025 | EMILIANO_URUENA | DATA_GROUPS | SPRINT2 #580

Uh oh!

Emilianouz commented Jul 11, 2025

Uh oh!

MorganDavid left a comment

Uh oh!

MorganDavid Jul 12, 2025

Uh oh!

MorganDavid Jul 12, 2025

Uh oh!

MorganDavid Jul 12, 2025

Uh oh!

MorganDavid Jul 12, 2025 •

edited

Loading

Uh oh!

MorganDavid Jul 12, 2025

Uh oh!

MorganDavid Jul 12, 2025

Uh oh!

MorganDavid Jul 12, 2025

Uh oh!

Uh oh!

	const [key, value] = [pair.slice(0,pair.indexOf('=')),pair.slice(pair.indexOf('=')+1)];
	const equalsIndex = pair.indexOf('=');
	const [key, value] = [pair.slice(0,equalsIndex),pair.slice(pair.indexOf('=')+1)];

	{input:{a : 1, b: 2}, expected:{ 1 : "a" , 2 : "b" }},
	{input:{a : 1, b: 1}, expected:/* What happens here? */ },

Uh oh!

LONDON | MAY_2025 | EMILIANO_URUENA | DATA_GROUPS | SPRINT2 #580

Are you sure you want to change the base?

LONDON | MAY_2025 | EMILIANO_URUENA | DATA_GROUPS | SPRINT2 #580

Uh oh!

Conversation

Emilianouz commented Jul 11, 2025

Changelist

Uh oh!

MorganDavid left a comment

Choose a reason for hiding this comment

Uh oh!

MorganDavid Jul 12, 2025

Choose a reason for hiding this comment

Uh oh!

MorganDavid Jul 12, 2025

Choose a reason for hiding this comment

Uh oh!

MorganDavid Jul 12, 2025

Choose a reason for hiding this comment

Uh oh!

MorganDavid Jul 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

MorganDavid Jul 12, 2025

Choose a reason for hiding this comment

Uh oh!

MorganDavid Jul 12, 2025

Choose a reason for hiding this comment

Uh oh!

MorganDavid Jul 12, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

MorganDavid Jul 12, 2025 •

edited

Loading