Skip to content

Glasgow | ITP May 25 | Mirabelle Morah | Data groups | Sprint 1 #579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

mirabellemorah
Copy link

Learners, PR Template

Self checklist

  • I have committed my files one by one, on purpose, and for a reason
  • I have titled my PR with REGION | COHORT_NAME | FIRST_NAME LAST_NAME | PROJ_NAME
  • I have tested my changes
  • My changes follow the style guide
  • My changes meet the requirements of this task

Changelist

Worked on problems

Questions

Nil

@mirabellemorah mirabellemorah added the Needs Review Participant to add when requesting review label Jul 11, 2025
@LonMcGregor LonMcGregor added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Participant to add when requesting review labels Jul 14, 2025
Copy link

@LonMcGregor LonMcGregor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work on this - I have one question about the mean.js file, it doesn't seem implemented. Other than that, good work on these tasks

}

// If even number of elements, this returns the average of the two middle elements
return (sortedNumbers[middleIndex - 1] + sortedNumbers[middleIndex]) / 2;
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good solution

function dedupe(list) {
return [...new Set(list)];
}
console.log(dedupe(['a','a','b','c','c'])); // returns ['a', 'b', 'c']

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good use of built-in Set feature

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

}
// If the sum is negative, return 0; otherwise, return the sum
const total = filterList.reduce((acc, curr) => acc + curr, 0);
return total;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good use of reduce function

// Write a function which takes an array as a parameter
// and swaps the first element with the last element

function swapFirstAndLast(arr) {}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this finished yet? Did you mean to commit this file here?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your review and yes please, you can ignore the prep folder and no action is needed here. It is for my draft practice only and not mandatory.

In the prep section for the entire module it asks us to create a prep directory to practice. So for every sprint, I have a prep folder where I create random tests, delete stuff and just practice there. :)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, that's fine. You are complete with this sprint, then. Good job!

@LonMcGregor LonMcGregor added 👀 Review Requirements Changes requested to meet requirements and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Jul 14, 2025
@mirabellemorah mirabellemorah added the Needs Review Participant to add when requesting review label Jul 14, 2025
Copy link

@LonMcGregor LonMcGregor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sprint complete.

// Write a function which takes an array as a parameter
// and swaps the first element with the last element

function swapFirstAndLast(arr) {}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, that's fine. You are complete with this sprint, then. Good job!

@LonMcGregor LonMcGregor added Complete Volunteer to add when work is complete and review comments have been addressed and removed 👀 Review Requirements Changes requested to meet requirements Needs Review Participant to add when requesting review labels Jul 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complete Volunteer to add when work is complete and review comments have been addressed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants