Skip to content

Sheffield|May-2025|Sheida Shabankari|Module-Data -Groups| Sprint-2 #574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

Sheffield|May-2025|Sheida Shabankari|Module-Data -Groups| Sprint-2 #574

wants to merge 13 commits into from

Conversation

sheida-shab
Copy link

Self checklist

  • I have committed my files one by one, on purpose, and for a reason
  • I have titled my PR with REGION | COHORT_NAME | FIRST_NAME LAST_NAME | PROJ_NAME
  • I have tested my changes
  • My changes follow the style guide
  • My changes meet the requirements of this task

Briefly explain your PR.

I have implemented and modified functions and wrote test cases that all passed and answer the questions.

@sheida-shab sheida-shab added the Needs Review Participant to add when requesting review label Jul 10, 2025
cjyuan
cjyuan reviewed Jul 12, 2025
View reviewed changes
@cjyuan cjyuan added Reviewed Volunteer to add when completing a review and removed Needs Review Participant to add when requesting review labels Jul 12, 2025
@sheida-shab sheida-shab added the Needs Review Participant to add when requesting review label Jul 12, 2025
@cjyuan
Copy link
Contributor

cjyuan commented Jul 13, 2025

Changes look good. Well done!

@cjyuan cjyuan added Complete Volunteer to add when work is complete and review comments have been addressed and removed Needs Review Participant to add when requesting review Reviewed Volunteer to add when completing a review labels Jul 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjyuan cjyuan cjyuan left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Complete Volunteer to add when work is complete and review comments have been addressed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sheida-shab @cjyuan