Glasgow | May 2025 | Salah Ahmed | Data Groups | Sprint 1 #569
+974
−736
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ove median calculation logic
avatarit
added
Needs Review
LonMcGregor
added
Review in progress
LonMcGregor
reviewed
Jul 14, 2025
| //Notes / Limitations: | ||
| //Time complexity is O(n²): Inefficient for large arrays. | ||
| //Mutates the input array: If you need to preserve the original, you'll need to copy it first. | ||
|
|
There was a problem hiding this comment.
Good analysis of this solution's complexity. Lots of nested loops within loops should be avoided where possible. Your other solution is clever, making use of existing javascript functionality.
| const numericElements = elements.filter(element => typeof element === 'number'); | ||
|
|
||
| // Return the sum of numeric elements | ||
| return numericElements.reduce((acc, curr) => acc + curr, 0); | ||
| } |
There was a problem hiding this comment.
Good use of the reduce function here
LonMcGregor
added
Reviewed
…for improved performance
LonMcGregor
added
Complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Self checklist
Changelist
I have solved all issues relaed to sprint 1 in Data Group