London | May-2025 | Mohamed Ibrahim | Module-Data-Groups | Alarm Clock #563
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MorganDavid
suggested changes
Jul 12, 2025
| const seconds = parseInt(input.value, 10); | ||
|
|
||
| if (isNaN(seconds) || seconds <= 0) { | ||
| alert("Enter a number greater than 0"); |
There was a problem hiding this comment.
nice job thinking about how to handle invalid input
| const minutes = String(Math.floor(remainingSeconds / 60)).padStart(2, "0"); | ||
| const seconds = String(remainingSeconds % 60).padStart(2, "0"); | ||
| document.getElementById("timeRemaining").textContent = `Time Remaining: ${minutes}:${seconds}`; | ||
| } | ||
|
|
||
| // DO NOT EDIT BELOW HERE |
There was a problem hiding this comment.
We should try to complete the task without editing below this line
There was a problem hiding this comment.
Thanks for the feedback! I moved them above the line as suggested, so nothing below was changed.
MorganDavid
added
Reviewed
illicitonion
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Briefly explain your PR.
Questions
Ask any questions you have for your reviewer.