London | ITP-May-2025 | Sisay Mehari | Module-Data-Groups | Sprint 1 #556
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modified: Sprint-1/implement/dedupe.js modified: Sprint-1/implement/dedupe.test.js modified: Sprint-1/implement/max.js modified: Sprint-1/implement/max.test.js modified: Sprint-1/implement/sum.js modified: Sprint-1/implement/sum.test.js modified: Sprint-1/refactor/includes.js modified: Sprint-1/stretch/aoc-2018-day1/solution.js
modified: Sprint-1/fix/median.js
Sisu860
added
Needs Review
fearcyf
reviewed
Jul 8, 2025
fearcyf
reviewed
Jul 8, 2025
fearcyf
reviewed
Jul 8, 2025
fearcyf
reviewed
Jul 8, 2025
fearcyf
reviewed
Jul 8, 2025
fearcyf
reviewed
Jul 8, 2025
There was a problem hiding this comment.
consider how you would code to catch errors such as file not being available. just a consideration, w3 schools is a website with good information
|
I can't see your median.tests file, please advise. Otherwise good work |
fearcyf
added
Reviewed
fearcyf
reviewed
Jul 11, 2025
fearcyf
reviewed
Jul 11, 2025
There was a problem hiding this comment.
Each type of error can be identified and returned however that should be discussed later in the course. Do your own research in the meantime.
fearcyf
reviewed
Jul 11, 2025
|
I have made the changes. Can you please tag the complete label? |
fearcyf
added
Complete
|
Sisay, I have now added the Complete Tag. @cjyuan, this sprint 1 should be ready to go forward now. |
|
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
✅ Completed Work Summary
This pull request includes completed implementations and refactors across several array utility functions, with full test coverage and a stretch challenge solution from Advent of Code.
📦 Core JavaScript Functions
Removes duplicate values from arrays while preserving order.
Tests cover:
Empty arrays
Arrays with and without duplicates
Arrays with mixed types (e.g., strings, numbers)
Finds the maximum numeric value in an array, ignoring non-numeric entries.
Improved handling for:
Empty arrays (returns -Infinity)
Arrays with only non-numeric values
Negative and decimal numbers
Calculates the sum of numeric values in an array, skipping non-numeric values.
Tested with:
Empty arrays
Arrays with negative and decimal numbers
Arrays with only non-number elements
Computes the median of numeric values in an array.
Enhancements include:
Skips non-numeric values
Returns null for empty or invalid arrays
Added comments and sample I/O for clarity
Rewrote the includes function to use a more readable for...of loop instead of a traditional for loop.
All original tests still pass.
🚀 Stretch Goal: Advent of Code 2018 - Day 1
solution.js
Implements calculateFrequency(changes) to compute resulting frequency from a list of changes like +1, -2, etc.
Starts from frequency 0
Handles input from file
Ensures all deltas are processed correctly
🧪 Testing
Comprehensive test coverage added for all updated and new functions.
Tests include:
Edge cases (e.g., empty arrays, invalid inputs)
Common use cases
Non-numeric filtering and robust input validation
Questions
None at the moment.