London | ITP-May-2025 | Seddiq Azam | Module-Data-Groups | Sprint 1

[sedazam]

Learners, PR Template

Self checklist

• I have committed my files one by one, on purpose, and for a reason
• I have titled my PR with REGION | COHORT_NAME | FIRST_NAME LAST_NAME | PROJ_NAME
• I have tested my changes
• My changes follow the style guide
• My changes meet the requirements of this task

Changelist

Briefly explain your PR.

🛠️ PR Summary: Sprint 1

This pull request includes all completed work covering core kata implementations, test coverage, refactoring, and a stretch goal from Advent of Code.

---

✅ Completed Work

📦 Core Katas

1. dedupe.js

• Removes duplicate elements while preserving order.
• Tests include:
  • Empty arrays
  • Mixed types (e.g., strings, numbers)
  • Arrays with repeated elements

2. max.js

• Returns the maximum number in an array, ignoring non-numeric values.
• Handles:
  • Empty arrays (-Infinity)
  • Negative numbers
  • Mixed types
  • Decimal numbers

3. sum.js

• Sums all numeric values in an array.
• Ignores non-number values.
• Bug fix: corrected accumulator misuse in .reduce().
• Handles:
  • Empty arrays
  • Negative and decimal numbers
  • Non-numeric elements

4. includes.js (Refactor)

• Refactored to use a for...of loop instead of a traditional for loop.
• All original tests continue to pass.

---

🚀 Stretch Goal: Advent of Code 2018 - Day 1

solution.js

• Implemented calculateFrequency(changes):
  • Computes resulting frequency from a list of changes (e.g., +1, -2).
  • Starts from frequency 0 and applies all deltas.
• Fixed syntax error: calculate Frequency → calculateFrequency.

---

🧪 Testing

• Comprehensive test coverage added for all implemented functions.
• Tests cover:
  • Edge cases
  • Common scenarios
  • Robust input handling

---

Questions

Ask any questions you have for your reviewer.

[LonMcGregor]

Good work on this sprint - you built very detailed test cases. You can close this PR now.

[LonMcGregor]

be careful of committing lots of commented-out code to git if it doesn't need to be there

[sedazam]

I agree, unnecessary information should not be included. Thank you for the information.