LONDON | MAY2025 | EMILIANO URUENA | DATA_GROUPS | Sprint-1 #546
Conversation
Emilianouz
added
📅 Sprint 1
AdnanGondal
added
Review in progress
| return null | ||
| } | ||
| // the next code from 13 to 16create a new Array called listFiltered checking if the elements are numbers and no NaN> | ||
| const listFiltered = list.filter(checkElement); |
There was a problem hiding this comment.
Using an anonymous function here will make this method more concise (instead of checkElement).
| return median | ||
| } else { | ||
| const median = listFiltered.splice(middleIndex, 1)[0]; | ||
| return median |
There was a problem hiding this comment.
Using an Inline return statement on this line and line 28 is best practice
| } | ||
| if (elements.length === 0) return '-Infinity'; | ||
| if (elements.length === 1) return elements; | ||
| let maxNum = [] |
There was a problem hiding this comment.
Why is maxNum an array? A number type as the return value is most appropriate for this function.
|
|
||
| ); | ||
| [ | ||
| { input: ['e','r','n','a','l','g','l'], expected: 'Family'}, |
There was a problem hiding this comment.
Is 'Family' the best value to return in this case? Why not return something like null.
| noNum.push(elements[i]) | ||
| } | ||
| } | ||
| if (elements.length === noNum.length) return 'Family' |
There was a problem hiding this comment.
Again, is returning 'Family' the most appropriate here? Why not either 0 or null?
| if (typeof elements[i] === 'number'){ | ||
| sum += elements[i]; | ||
| } else { | ||
| noNum.push(elements[i]) |
There was a problem hiding this comment.
Is there a better way to check if the array contains no numbers, instead of making a new array and adding all the elements to it? Every array in your code will use more memory, and for very large inputs this will be inefficient.
|
A good start - but there is still some work to do. Please address the comments and I will review it again. |
AdnanGondal
added
Reviewed
Self checklist
Changelist
Sprint 1 - Module DATA GROUPS
COMMITS: