London | May-2025 | Halyna Kozlovska | Module Data Groups | Sprint 1 #542
Conversation
- fix and improve median calculation logic
- refactor findMax function; - add comprehensive tests covering all cases
- refactor max.test.js to use a single describe block
- refactor sum function; - add comprehensive tests for all cases: empty arrays, single numbers, negative numbers, decimals, mixed types, and arrays with only non-numeric values.
- implement dedupe function; - add tests to verify the function's behavior for various cases: empty arrays, arrays with no duplicates, array with string or number duplicates
- refactor includes function to use for...of loop; - update tests assertions to use toBe instead of toEqual; - fixed the empty array test to include a target argument
halyna-k
added
📅 Sprint 1
AdnanGondal
added
Review in progress
| @@ -1 +1,10 @@ | |||
| function dedupe() {} | |||
| function dedupe(array) { | |||
| let result = []; | |||
There was a problem hiding this comment.
For very large arrays, a Set can provide better performance than using an Array. Consider updating this implementation to use a set. See here: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Set
There was a problem hiding this comment.
@AdnanGondal Thanks for your comment — good point! Using a Set makes lookups faster (O(1) vs O(n)) and keeps values unique, which is great for large arrays. Here the time and space difference is small because the dataset is tiny, but I’ll keep Set in mind for future cases where performance matters more.
| sum += element; | ||
| } | ||
| } | ||
| return Math.round(sum * 100) / 100;; |
There was a problem hiding this comment.
Can you tell me what this line does?
There was a problem hiding this comment.
@AdnanGondal Line 9 rounds the total sum to two decimal places before returning it.
AdnanGondal
added
Reviewed
AdnanGondal
added
Complete
Learners, PR Template
Self checklist
Changelist
Questions
Ask any questions you have for your reviewer.