Skip to content
This repository was archived by the owner on Jun 18, 2024. It is now read-only.

Conversation

@kelvinkipruto
Copy link
Contributor

Description

This PR updates the project to use NextJS 13.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

@vercel
Copy link

vercel bot commented Jul 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
pesayetu ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 21, 2023 9:13am

@kelvinkipruto kelvinkipruto marked this pull request as ready for review July 21, 2023 07:09
Copy link
Member

@kilemensi kilemensi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM


I'm assuming we're not merging this one also.

?.getBoundingClientRect();

if (firstElement && secondElement) {
// eslint-disable-next-line no-unsafe-optional-chaining
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No easy way to fix these? Lots of disabling.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me look at fixing it.

Co-authored-by: Clemence Kyara <kilemensi@users.noreply.github.com>
@kelvinkipruto
Copy link
Contributor Author

I'm assuming we're not merging this one also.

Yes. We will close it if it is ok.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants