Skip to content

Fix Bugs With Multiple Highlight Providers #346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

thecoolwinter
Copy link
Collaborator

Description

Fixes a few issues when using multiple highlight providers.

  • RangeStore did not clamp its output to only the requested range when querying for runs in a specific range. This broke an assumption by the styled store container, which broke the resulting highlighted ranges.
    • Adds some randomized testing to the query method to ensure that runtime contract is maintained.
  • When reordering or adding new providers, their inferred priority would be lost.

Related Issues

  • N/A

Checklist

  • I read and understood the contributing guide as well as the code of conduct
  • The issues this PR addresses are related to each other
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • My changes are all related to the related issue above
  • I documented my code

Screenshots

N/A

@thecoolwinter thecoolwinter added the bug Something isn't working label Jul 21, 2025
@thecoolwinter thecoolwinter merged commit fe51d30 into CodeEditApp:main Jul 21, 2025
2 checks passed
@thecoolwinter thecoolwinter deleted the fix-lsp-highlight-provider branch July 21, 2025 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant