Skip to content

Make status bar an actual divider #1731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Conversation

xyzqm
Copy link
Contributor

@xyzqm xyzqm commented May 22, 2024

Description

Previously, the status bar was just attached to the bottom of the editor, whereas in Xcode, it acts essentially as a thick divider. This PR aims to get the status bar to be more like Xcode's.

Relevant SO article: https://stackoverflow.com/questions/40643604/can-i-use-a-custom-view-as-a-nssplitviews-divider/40659541

Related Issues

Checklist

  • fix bug detailed in video below
  • get maximization/collapse buttons to work
  • I read and understood the contributing guide as well as the code of conduct
  • The issues this PR addresses are related to each other
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • My changes are all related to the related issue above
  • I documented my code

Screenshots

As shown in the video below, normal drags + collapsing the editor work fine, but for some reason collapsing the terminal causes really jank behavior.

Screen.Recording.2024-05-22.at.2.43.57.PM.mov

@austincondiff
Copy link
Collaborator

austincondiff commented May 23, 2024

Does this include your work with #1701? I noticed that it was closed.

@xyzqm
Copy link
Contributor Author

xyzqm commented May 23, 2024

Yes, the goal is to eventually integrate the changes from #1701, but I want to iron out the status bar first.

@tom-ludwig
Copy link
Member

tom-ludwig commented Aug 14, 2024

@danielzsh Any updates on the status? Is this still in progress?

@xyzqm
Copy link
Contributor Author

xyzqm commented Aug 14, 2024

Haven't worked on it in a while since it was way too hard to get working :( I tried two approaches:

  1. making the divider thick and drawing the status bar over it and
  2. having 3 views in the split, with the middle one being the status bar
    But they both led to very jank results (which I can't quite recall at the moment).

@austincondiff
Copy link
Collaborator

I don't think this is necessary anymore with the recent changes we've made to the utility area. Thanks so much for the effort @danielzsh!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐞 Status Bar does not update when workspace is first opened
3 participants