Skip to content

perf(search): Resolved issue with SearchKit #1688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 1, 2024

Conversation

tom-ludwig
Copy link
Member

@tom-ludwig tom-ludwig commented Apr 27, 2024

Description

This PR addresses an issue where the search algorithm was unable to process certain special characters (e.g.,, (, *, :). This limitation prevented users from finding content that included these characters in their queries.

For example, searching for "info": in a JSON file would not return any results due to this limitation.

Contents.json:

{
    "info": "xcode": {
        [...] 
    }
}

The fix in this PR corrects the search algorithm to handle these special characters, allowing users to successfully search for content that includes them.

Related Issues

na

Checklist

  • I read and understood the contributing guide as well as the code of conduct
  • The issues this PR addresses are related to each other
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • My changes are all related to the related issue above
  • I documented my code
  • fix tests

Screenshots

@tom-ludwig tom-ludwig self-assigned this Apr 27, 2024
@austincondiff austincondiff marked this pull request as ready for review April 29, 2024 04:07
@austincondiff austincondiff marked this pull request as draft April 29, 2024 04:07
@tom-ludwig tom-ludwig marked this pull request as ready for review April 29, 2024 16:47
@tom-ludwig
Copy link
Member Author

Finally ready for review. It was tougher to come up with those 21 lines than the original 400. Good thing I found a bug during testing, which I've fixed now. Could you guys test some queries on your projects to make sure everything's working right?

@tom-ludwig tom-ludwig requested a review from a team April 29, 2024 16:51
@matthijseikelenboom
Copy link
Contributor

Might want to put some XCTests in place as well?

@matthijseikelenboom matthijseikelenboom merged commit e69a433 into CodeEditApp:main May 1, 2024
2 checks passed
@thecoolwinter thecoolwinter added the bug Something isn't working label Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants