Refactored WorkspaceClient and sidebar #1243
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Transfer project navigator bottom * Transfer TableViewCell abstractions * Transfer over project manager outline view * Get proj navigator sidebar working again * Rename OutlineView -> ProjectNavigatorOutlineView for clarity * Remove debug statements * Fix incorrect comment headers * Change old AE assets to new CE assets * Add vscode-style toolbar * Disable vertical sidebar by default * Make deletion messages more descriptive * Fix table view cell alignments
|
Please resolve all merge conflicts. Marking as a draft until then. |
matthijseikelenboom
requested review from
Wouter01,
RayZhao1998,
austincondiff,
0xWDG,
lukepistrol and
thecoolwinter
and removed request for
RayZhao1998
0xWDG
reviewed
May 1, 2023
0xWDG
reviewed
May 1, 2023
CodeEdit/Features/NavigatorSidebar/OutlineView/FileSystemTableViewCell.swift
Show resolved
Hide resolved
0xWDG
reviewed
May 1, 2023
CodeEdit/Features/NavigatorSidebar/OutlineView/StandardTableViewCell.swift
Show resolved
Hide resolved
0xWDG
approved these changes
May 1, 2023
|
Could we not carry over functionality so we do not have to reopen #1029 and #1018? Or would this take to long (just want to understand)? We have already encountered a good amount of regressions as of late so I am a little apprehensive about merging something that will cause even more regression. In the interest of moving fast though, if there is a immediate plan to tackle this, that might be okay. |
austincondiff
approved these changes
May 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR includes improvements to the Sidebar carried over from AuroraEditor. It contains under the hood and architecture improvements as well as some functional quality of life things. It also contains a new/updated implementation of the
WorkspaceClientwhich has been renamed toCEWorkspaceFileManager.Related Issues
Also adds the foundation for:
But reopens (functionality will eventually be added):
Checklist
Screenshots
N/A