Refactored Activities for clarity and a consistent API #1680
CI-pull-request.yml
on: pull_request
SwiftLint
/
SwiftLint
8s
Testing CodeEdit
/
Testing CodeEdit
Annotations
10 errors
SwiftLint / SwiftLint:
CodeEdit/Features/SourceControl/Accounts/Networking/GitJSONPostRouter.swift#L167
SwiftLint rule 'non_optional_string_data_conversion' did not trigger a violation in the disabled region; remove the disable command (superfluous_disable_command)
|
SwiftLint / SwiftLint:
CodeEdit/Features/SourceControl/Accounts/Networking/GitJSONPostRouter.swift#L128
SwiftLint rule 'non_optional_string_data_conversion' did not trigger a violation in the disabled region; remove the disable command (superfluous_disable_command)
|
SwiftLint / SwiftLint:
CodeEdit/Features/SourceControl/Accounts/Networking/GitJSONPostRouter.swift#L74
SwiftLint rule 'non_optional_string_data_conversion' did not trigger a violation in the disabled region; remove the disable command (superfluous_disable_command)
|
SwiftLint / SwiftLint:
CodeEdit/Features/Documents/WorkspaceDocument/WorkspaceDocument+Find.swift#L186
Prefer failable `String(bytes:encoding:)` initializer when converting `Data` to `String` (optional_data_string_conversion)
|
SwiftLint / SwiftLint:
CodeEdit/Features/Documents/WorkspaceDocument/WorkspaceDocument+Index.swift#L27
Lines should not have trailing whitespace (trailing_whitespace)
|
SwiftLint / SwiftLint:
CodeEdit/Features/NavigatorArea/FindNavigator/FindNavigatorResultList/FindNavigatorListViewController.swift#L158
Prefer `a is X` to `a as? X != nil` (prefer_type_checking)
|
SwiftLint / SwiftLint:
CodeEdit/Features/Tasks/Models/CEActiveTask.swift#L68
Prefer failable `String(bytes:encoding:)` initializer when converting `Data` to `String` (optional_data_string_conversion)
|
SwiftLint / SwiftLint:
CodeEdit/Features/Settings/Views/ExternalLink.swift#L58
`@escaping` must have a trailing space before the associated type (attribute_name_spacing)
|
SwiftLint / SwiftLint:
CodeEditTests/Features/TerminalEmulator/Shell/ShellTests.swift#L66
Prefer failable `String(bytes:encoding:)` initializer when converting `Data` to `String` (optional_data_string_conversion)
|
SwiftLint / SwiftLint:
CodeEditTests/Features/TerminalEmulator/Shell/ShellTests.swift#L48
Prefer failable `String(bytes:encoding:)` initializer when converting `Data` to `String` (optional_data_string_conversion)
|