-
Notifications
You must be signed in to change notification settings - Fork 69
Enhanced transaction tracking #87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for paisable canceled.
|
@Avdhesh-Varshney @archa8 kindly view my pr and let me know if any changes are to be made. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @rohIta-k, thank you for opening the PR. You have added a separate lockfile outside the frontend and backend folders. Could you please remove it to avoid confusion as it serves no practical purpose as far as I know?
Also, @rohIta-k, kindly resolve the conflicts in |
@archa8 can you check now? I have merged conflicts and removed lockfile |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as intended. LGTM!
Description
Database and API Enhancements:
Transaction Category API Structure:
User Interface Modifications:
ManageCategoriesModal Refactor: Modified the modal to include separate, dedicated sections for managing Income and Expense categories, while preserving the original category management logic.
TransactionModal Overhaul:
Implemented a two-view system within the modal:
Expense Form
Income Form
Added a note field to both the Expense and Income forms.
Included a switch link in each view to allow users to toggle between the Income and Expense forms easily.
Income Form Logic: Removed the standard "name" field; the transaction name is now automatically generated as [Category Name] Income.
Transaction Submission and Validation: Updated the handleSubmit function to include a soft warning when a submitted transaction would result in a negative account balance. The user is prompted to confirm submission to override the warning.
Transactions Page Enhancements:
Created the new TransactionDetailsModal component, which displays the complete details of a selected transaction when the Details link is clicked.
Modified the endpoints for expense and income categories in the documentation.
Related Issue
Fixes #24
Motivation and Context
Types of Changes
How Has This Been Tested?
Tested it by adding both expense and income transaction. Verified soft warning with an expense that makes the balance negative. Verified the details link to correctly show all the details of the transactions. Verified all of this also after deployment.
Screenshots (if applicable):
Checklist