-
Notifications
You must be signed in to change notification settings - Fork 69
Feat: add bulk delete, icons and enhance UI #70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for paisable ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds bulk delete functionality for transactions, allowing users to select multiple transactions and delete them in a single operation. The UI has been modernized with icon-based buttons and enhanced hover effects for better user experience.
- Added bulk selection with individual and master checkboxes
- Implemented bulk delete with confirmation dialog
- Replaced text buttons with lucide-react icons for actions and navigation
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 3 comments.
File | Description |
---|---|
frontend/src/pages/TransactionsPage.jsx | Implements bulk selection state, bulk delete functionality, and replaces text buttons with icons from lucide-react |
frontend/package.json | Adds lucide-react dependency for icon components |
Files not reviewed (1)
- frontend/package-lock.json: Language not supported
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 2 out of 3 changed files in this pull request and generated 3 comments.
Files not reviewed (1)
- frontend/package-lock.json: Language not supported
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
@archa8 Please review this PR and tell me if you want any suggestions to be added. |
Kindly cross-link the corresponding issue. Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tanmaygautam11 The Edit and Delete icons work as intended, but the bulk delete doesn't work. For this, you'll need to make changes to backend/routes/transactionRoutes.js
where you'll have to write the code to handle bulk delete. I have resolved the conflicts that were occurring in the TransactionsPage.jsx
, so kindly pull the changes in your branch and then update the corresponding code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 2 out of 3 changed files in this pull request and generated 3 comments.
Files not reviewed (1)
- frontend/package-lock.json: Language not supported
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Hey @tanmaygautam11, kindly use the existing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 4 out of 5 changed files in this pull request and generated 3 comments.
Files not reviewed (1)
- frontend/package-lock.json: Language not supported
Comments suppressed due to low confidence (1)
backend/controllers/transactionController.js:1
- Using
alert()
for error handling in modern React applications is not a best practice. Consider using a proper notification system or state-based error handling instead.
const IncomeExpense = require('../models/IncomeExpense');
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Hey @archa8, I have looked at the copilot suggestions and added the important ones. Also I have improved debouncing logic in the code. Please review the changes and tell me if you want any other changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and works as intended. LGTM!
Add bulk delete functionality with enhanced UI improvements and added icons in place of text buttons.
Description
This PR introduces bulk delete functionality for transactions, allowing users to select multiple transactions and delete them in a single operation. Additionally, the UI has been enhanced with modern hover effects and icon-based navigation for better user experience.
Key Features Added:
Related Issue
Fixes #25
Motivation and Context
Users frequently need to delete multiple transactions at once (e.g., duplicate entries, bulk cleanup, imported data corrections). The previous implementation required deleting transactions one by one, which was time-consuming and inefficient. This enhancement significantly improves user productivity by enabling bulk operations while maintaining a clean, professional interface.
Types of Changes
How Has This Been Tested?
Test Scenarios:
Screenshots (if applicable):
Checklist