budgets added #44
budgets added #44
Conversation
✅ Deploy Preview for paisable ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
@archa8 can u plz review |
|
@archa8 can u plz review this one as well! Thanks. |
There was a problem hiding this comment.
Hey, thank you for the contribution! The core functionality works well. However, it would be awesome if you could follow design standards and style the text boxes/areas in the Add Budget card with some padding. Additionally, I have left comments for two of the changed files. Thank you!
|
@pranjalarora98 There are also some conflicts due to files being changed in the latest PRs (for example, I merged the PR for the Settings feature), so kindly include your changes carefully in order not to break the existing features in prod. |
pranjalarora98
force-pushed
the
feature/pranjal/budget-functionality
branch
from
f13bead to
7676bca
Compare
|
@archa8 I have made the required changes and also the styling of add budget modal.Please let me know if any other changes are there? |
|
@archa8 can u plz review this as well |
|
Could you please merge the recent changes and push your branch once? |
|
@archa8 yes its already pushed |
….com/pranjalarora98/paisable into feature/pranjal/budget-functionality
|
Hey @pranjalarora98, there are a lot of conflicts in the files which are making it tough for me to review you PR as the code is constantly breaking. Could you please try to resolve them once on your system? Please pull the changes as I tried to resolve some conflicts. |
|
ok @archa8 i will resolve the conflicts for thiss branch as well.I have fixed in recurring transactions branch few mins back |
…udget-functionality
…udget-functionality
|
@archa8 i have resolved the conflicts |
|
Hey @pranjalarora98, there are still conflicts in the routes section of |
…udget-functionality
|
Fixed @archa8 |
Categories are no more visible in the dropdown |
|
@archa8 fixed conflicts and endpoint was changed I had updated it |
|
@archa8 can u plz add hacktoberfest-accepted label to the PR"s |
3 participants
Added Budget Controller, Model and integrated with Transactions
Description
Added a Budgets feature
Related Issue
Fixes #3