Feature/pranjal/paisable recurring transactions #37
Conversation
✅ Deploy Preview for paisable ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Hi, thanks for the contribution!
The core functionality has been implemented well and works fine. However, the black heading/text doesn't match the dark mode of the site and should be changed accordingly and there should be some indication that the date field is for the next due date for an easy UX.
Also I see some unnecessary changes like changing single quotes to double quotes, extra spaces and deleting and then re-adding import statements. Kindly remove these changes.
|
Ok @archa8 sure.Can you take a look at other PR also for implementing budgets. If any changes I will fix right away in both. Thanks |
…ps://github.com/pranjalarora98/paisable into feature/pranjal/paisable-recurring-transactions
|
@archa8 i have made the required changes, but others changes r also being shown in diff like README.md etc |
There was a problem hiding this comment.
The date field can't be edited here. Other fields are fine. And it is not very clear what you mean by Start Date in the add recurring transactions card because the same date occurs as the "Next Due" in the table. Kindly fix this. Also, you haven't pushed the lockfile changes for the backend for node-cron. Kindly push that too.
|
@archa8 actually in the listing for any item initially the next due date will be same as start date.Then it will get updated accordingly as cron proceeds depending on week, month etc logic |
|
@archa8 apart from that i have pushed the package lock json and disabled the date edit from add recurring transaction modal |
|
Hey @pranjalarora98, I didn't mean that you should remove the edit functionality from date. Sorry for the confusion. I meant that I wasn't able to edit the date, if I entered it incorrectly and I understood your next due logic. Just make sure that the date can be edited. Thank you and sorry again for the inconvenience. |
|
@archa8 sorry I misunderstood it. I have added edit date functionaly back |
There was a problem hiding this comment.
There is an error in your recurringTransactionController.jsx file, which is causing the date not to update in the table even if it is changed in the card.
To solve this, write a new helper function at top of the file which calculates the correct upcoming due date. You can ping me if you need help.
|
@archa8 i have moved the update date logic to utils and utilised same in cron and controller |
…aisable-recurring-transactions
|
@archa8 I think also need to add hacktoberfest accepted label to the PR? As its not counted |
|
@archa8 As in hacktoberfest website it shows not accepted still |
3 participants
Recurring Transactions feature added
Description
Related Issue
Fixes #6
Types of Changes
Added Controller,Modal,Route and a cron job for updating transactions