Skip to content

feat: allow use of alternate KMS keys #731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: allow use of alternate KMS keys #731

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions API.md
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

13 changes: 13 additions & 0 deletions src/providers/ecs.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,6 +157,11 @@ export interface EcsRunnerProviderProps extends RunnerProviderProps {
*/
readonly maxInstances?: number;

/**
* Options for runner instance storage volume.
*/
readonly storageKey?: cdk.aws_kms.IKey;

/**
* Size of volume available for launched cluster instances. This modifies the boot volume size and doesn't add any additional volumes.
*
Expand Down Expand Up @@ -263,6 +268,12 @@ export class EcsRunnerProvider extends BaseProvider implements IRunnerProvider {
});
}

/**
* Launch template for the created instance
*/
public launchTemplate?: ec2.LaunchTemplate;


/**
* Cluster hosting the task hosting the runner.
*/
Expand Down Expand Up @@ -395,6 +406,8 @@ export class EcsRunnerProvider extends BaseProvider implements IRunnerProvider {
volumeType: props.storageOptions?.volumeType,
iops: props.storageOptions?.iops,
throughput: props.storageOptions?.throughput,
encrypted: props.storageKey ? true : undefined,
kmsKey: props.storageKey ?? undefined,
},
},
},
Expand Down
Loading