Fix external slider updates #1400
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While I'm not following the logic in that code path, the idea seems to be that it should do an early return if the new value was not processed yet. And all that is fine, except that it was using `last_changed` instead of `last_updated`. For lights, it means that it only reacted to lights being turned on or off, not when the brightness was changing. Resolves Clooos#1367.
|
OK, while this change indeed fixes the bug mentioned in the ticket, I don't think it can be merged as is. It seems that it somewhat breaks the live update feature, as now changes done by the component are now feedback back as the outside changes, and it ends up being a bit buggy. I thought that the check for |
|
In my visual-styling-module, I have integrated slider updates. Maybe there is something in the code that helps? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While I'm not following the logic in that code path, the idea seems to be that it should do an early return if the new value was not processed yet.
And all that is fine, except that it was using
last_changedinstead oflast_updated. For lights, it means that it only reacted to lights being turned on or off, not when the brightness was changing.Resolves #1367.