-
-
Notifications
You must be signed in to change notification settings - Fork 105
Slider does not update for brightness if adjusted outside of the card after being adjusted in the card #1367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hi and thank again for the feedback! I will check that! |
@StaleLoafOfBread does the value update if you keep moving the mouse outside the card? I'm not really able to reproduce it the way it's described, but it's very possible that it's related to this fix: #1395 Basically, if you have live updates on, you move the mouse (e.g. outside the card) and stop the mouse movement, the value will not update, as the last mouse move updates are throttled and the value does not update. |
@AlexDaniel By "outside of the card" I meant adjusting it not via the card but rather another card, service call, automation, etc. Additional info below:
type: custom:bubble-card
card_type: button
modules:
- default
button_type: slider
entity: light.living_room
|
Ahhhh, you're right! Sorry for not getting it right away. I was able to reproduce it, will take a look later. |
While I'm not following the logic in that code path, the idea seems to be that it should do an early return if the new value was not processed yet. And all that is fine, except that it was using `last_changed` instead of `last_updated`. For lights, it means that it only reacted to lights being turned on or off, not when the brightness was changing. Resolves Clooos#1367.
OK, the fix for lights is right here: #1400 |
@AlexDaniel Funnily enough, I am the one who added That PR has more info that might help clear up the differences but basically For example, lets say you had a sensor whose value is the current hour. Let's assume this sensor checks the current hour every minute. That sensor's |
@StaleLoafOfBread but is that connected to the attributes? If I get it right, when we change the brightness of a light, the main state (on/off) does not change. So, naturally |
@AlexDaniel {{ states['light.living_room'].state }}
{{ states['light.living_room'].attributes.brightness }}
{{ states['light.living_room'].last_changed }}
{{ states['light.living_room'].last_updated }} |
@AlexDaniel Not sure if its helpful but I just learned of |
Hi! I just found the cause of this! This fix will be part of the next beta 😄 |
- [x] v3.0.0-beta.5/6 fails to render dashboard on some devices #1461 #1462 #1476 - [x] Light slider with hold to slide (default new behavior) are now limited to min 1%, to turn it off, just tap on the card. You can change that in the editor, or in YAML with `allow_light_slider_to_0: true`. #1295 - [x] Bubble backdrop color no longer works as expected #1294 - [x] Relative time formatting inconsistent with Home Assistant #1228 - [x] [3.0.0-beta.6] Slider doesnt work as expected, when entity step size is not 1 #1478 - [x] Slider does not update for brightness if adjusted outside of the card after being adjusted in the card #1367 - [x] Inconsistent and / or wrong color when using sub buttons on a slider #1448 - [x] All buttons are now hidden when a card’s entity is unavailable (like in a media player or cover card) #1453
The new beta is here! 😄 https://github.com/Clooos/Bubble-Card/releases/tag/v3.0.0-beta.7 |
@Clooos out of curiosity, what was the fix? |
I removed some parts of the code that was used for preventing the slider to move after an update, but I'm planning to rework this a little bit. |
Uh oh!
There was an error while loading. Please reload this page.
Describe the bug
Slider does not update for brightness if adjusted outside of the card after being adjusted in the card
To Reproduce
Steps to reproduce the behavior:
button
slider
card attached to a lightExpected behavior
The slider should update. In my screenshot the slider should fill up the bar. This expected behavior does occur if you do not adjust the brightness via the card before adjusting outside of the card.
Screenshots
YAML
If applicable, add any relevant YAML code.
Your code here
Informations (please complete the following information):
v2.5.0-beta.9
Additional context
Add any other context about the problem here.
Thank you! 🍻
The text was updated successfully, but these errors were encountered: