Skip to content

Adding additional log detail #440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 18, 2024
+8 −5
Merged

Adding additional log detail #440

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion VERSION
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
v1.2.0
v1.2.1
3 changes: 3 additions & 0 deletions src/main/java/com/clickhouse/kafka/connect/sink/ClickHouseSinkTask.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,10 @@ public void start(Map<String, String> props) {
@Override
public void put(Collection<SinkRecord> records) {
try {
long putStat = System.currentTimeMillis();
this.proxySinkTask.put(records);
long putEnd = System.currentTimeMillis();
LOGGER.info("Put records: {} in {} ms", records.size(), putEnd - putStat);
} catch (Exception e) {
LOGGER.trace("Passing the exception to the exception handler.");
boolean errorTolerance = clickHouseSinkConfig != null && clickHouseSinkConfig.isErrorsTolerance();
Expand Down
8 changes: 4 additions & 4 deletions src/main/java/com/clickhouse/kafka/connect/sink/processing/Processing.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,8 +178,8 @@ public void doLogic(List<Record> records) throws IOException, ExecutionException
stateProvider.setStateRecord(new StateRecord(topic, partition, rightRangeContainer.getMaxOffset(), rightRangeContainer.getMinOffset(), State.AFTER_PROCESSING));
break;
case ERROR:
throw new RuntimeException(String.format("State MISMATCH given [%s] records for topic: [%s], partition: [%s], minOffset: [%s], maxOffset: [%s]",
records.size(), topic, partition, rangeContainer.getMinOffset(), rangeContainer.getMaxOffset()));
throw new RuntimeException(String.format("State MISMATCH given [%s] records for topic: [%s], partition: [%s], minOffset: [%s], maxOffset: [%s], expectedMinOffset: [%s], expectedMaxOffset: [%s]",
records.size(), topic, partition, rangeContainer.getMinOffset(), rangeContainer.getMaxOffset(), stateRecord.getMinOffset(), stateRecord.getMaxOffset()));
}
break;
case AFTER_PROCESSING:
Expand Down Expand Up @@ -212,8 +212,8 @@ public void doLogic(List<Record> records) throws IOException, ExecutionException
stateProvider.setStateRecord(new StateRecord(topic, partition, rightRangeContainer.getMaxOffset(), rightRangeContainer.getMinOffset(), State.AFTER_PROCESSING));
break;
case ERROR:
throw new RuntimeException(String.format("State MISMATCH given [%s] records for topic: [%s], partition: [%s], minOffset: [%s], maxOffset: [%s]",
records.size(), topic, partition, rangeContainer.getMinOffset(), rangeContainer.getMaxOffset()));
throw new RuntimeException(String.format("State MISMATCH given [%s] records for topic: [%s], partition: [%s], minOffset: [%s], maxOffset: [%s], expectedMinOffset: [%s], expectedMaxOffset: [%s]",
records.size(), topic, partition, rangeContainer.getMinOffset(), rangeContainer.getMaxOffset(), stateRecord.getMinOffset(), stateRecord.getMaxOffset()));
}
}
}
Expand Down
Loading