Skip to content

feat: add ssh key authentication support #1602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

shivanshuraj1333
Copy link
Contributor

Adds fix for #1601
related to:
ClickHouse/ch-go#350
ClickHouse/ch-go#1075
ClickHouse/ClickHouse#41109

Summary

Adds ssh key auth support

Checklist

Delete items not relevant to your PR:

  • Unit and integration tests covering the common scenarios were added
  • A human-readable description of the changes was provided to include in CHANGELOG
  • For significant changes, documentation in https://github.com/ClickHouse/clickhouse-docs was updated with further explanations or tutorials

@shivanshuraj1333 shivanshuraj1333 force-pushed the feat/ssh branch 2 times, most recently from 7adac98 to c532491 Compare July 17, 2025 05:20
@shivanshuraj1333
Copy link
Contributor Author

@ernado ptal when you've some bandwidth

Copy link
Member

@SpencerTorres SpencerTorres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar comments to #1596, I think we should try to improve the testing here.

The unit tests can stay where they are, but it would be nice to have an integration test for this. We have a resources folder where we could mount and test SSH auth with the ClickHouse server container.

I like the client options, being able to provide a file path via URL seems convenient for external tools dependent on the driver + a URL. I think the custom signer is more useful though, I don't want to have too many file system operations within the driver so it's good to give the user that option.

I'm actually not familiar with the authentication process with SSH and ClickHouse. Can you provide some more info on the structure of the exchange and the limitations?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants